[Mailman-Developers] [ mailman-Patches-567488 ] possible fix for Hold.py check order

noreply@sourceforge.net noreply@sourceforge.net
Thu, 08 Aug 2002 10:46:14 -0700


Patches item #567488, was opened at 2002-06-11 13:15
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=567488&group_id=103

Category: list administration
Group: Mailman 2.0.x
>Status: Closed
>Resolution: Out of Date
Priority: 5
Submitted By: Jeff Garvas (jgarvas)
Assigned to: Nobody/Anonymous (nobody)
Summary: possible fix for Hold.py check order

Initial Comment:
I don't like the way Mailman checks posts in Hold.py -- I 
posted to mailman-users and created a bug, but this 
was probably too low of a priority for anyone to notice it.

Basically I want to know if a user posting to a list is a 
subscriber (even if the list is moderated) when the list is 
in "subscriber only" mode.

I went into Hold.py, knowing almost nothing about 
Python, and basically took the if block that checks for 
moderated status and moved it below the if block that 
checks for subscriber status.

I created this patch by putting my version of Hold.py in 
the root of the directory you get when you un-tar 
mailman, then I ran:

diff -C 2 Mailman/Handlers/Hold.py Hold.py

This might not be the proper way to make the patch file, 
but I've never done it before.  

I would like some input/feedback on if this is safe.  I 
can't fathom this breaking anything, but others obviously 
know this code much better than I do -- I just learned 
how to compile my python script last night ;)

-Jeff


----------------------------------------------------------------------

>Comment By: Barry A. Warsaw (bwarsaw)
Date: 2002-08-08 13:46

Message:
Logged In: YES 
user_id=12800

Your patch looks fine, but I'm closing it anyway. ;)  It's
out of date for MM2.1.  Thanks though!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=567488&group_id=103