[Mailman-Developers] VERP_DELIVERY_INTERVAL not yet functional ?

[Dan Mick]

        if mm_cfg.VERP_DELIVERY_INTERVAL > 0:
            if mm_cfg.VERP_DELIVERY_INTERVAL == 1:
                # VERP every time
                msgdata['verp'] = 1
            elif not int(mlist.post_id) % mm_cfg.VERP_DELIVERY_INTERVAL:
                msgdata['verp'] = 1

Other than possible precedence problems in that elif condition,
which casual testing seems to disallow (but I'd parenthesize 
anyway), it seems to me that setting 3 should cause every 3rd
message to be VERPed.

But in my testing it does not, and adding parentheses fixes it.
I'm too lazy to research further, as I believe the parens
should be there every time there's potential confusion.

Index: OutgoingRunner.py
===================================================================
RCS file: /cvsroot/mailman/mailman/Mailman/Queue/OutgoingRunner.py,v
retrieving revision 2.7
diff -u -r2.7 OutgoingRunner.py
--- OutgoingRunner.py   2001/12/27 07:08:00     2.7
+++ OutgoingRunner.py   2002/02/05 23:36:20
@@ -49,7 +49,7 @@
             if mm_cfg.VERP_DELIVERY_INTERVAL == 1:
                 # VERP every time
                 msgdata['verp'] = 1
-            elif not int(mlist.post_id) % mm_cfg.VERP_DELIVERY_INTERVAL:
+            elif not (int(mlist.post_id) % mm_cfg.VERP_DELIVERY_INTERVAL):
                 msgdata['verp'] = 1
         # Fortunately, we do not need the list lock to do deliveries.
         handler = mm_cfg.DELIVERY_MODULE


> what should one set in order to have VERP but not always?
> If I set VERP_DELIVERY_INTERVAL=3 it never verps.
> If I set VERP_DELIVERY_INTERVAL=1 it always verps.
> 
> Does it apply only to lists not yet created?
> Did I forget to set one variable?
> 
> (I'm using today's CVS version. I had the same trouble a while ago.
> Personalization and other verp features work correctly.)
> 
> -- Fil
> 
> 
> _______________________________________________
> Mailman-Developers mailing list
> Mailman-Developers@python.org
> http://mail.python.org/mailman/listinfo/mailman-developers