[Mailman-Developers] gate_news still broken in 2.1b..

Barry A. Warsaw barry@zope.com
Tue, 26 Feb 2002 01:20:23 -0500

>>>>> "RJ" == Ron Jarrell <jarrell@vt.edu> writes:

    RJ> Ok, mailman installs now, and large chunks of it are working,
    RJ> sans, apparently, any support for gzipping anymore since I got
    RJ> three pages of errors trying to link zlib.  However, gate_news
    RJ> is still doing what I reported a month or two ago... If I
    RJ> email a messages to my gated test list, I get this i the
    RJ> errors file:

    RJ> Feb 25 17:44:21 2002 (17842) (NNTPDirect) NNTP error for list
    RJ> "rontest": 441 437 No colon-space in "From
    RJ> jarrell@lennier.cc.vt.edu Mon Feb 25 17:44:00 2002 " header

    RJ> For some reason gate_news is passing the unix mailbox "From "
    RJ> header to the news server, who, understandably, doesn't like
    RJ> it.

Ah, I've been confused.  It's not gate_news that's broken (that's the
NNTP->mail gateway), it's NewsRunner.py (the mail->NNTP) gateway.  The
fix seems simple.  Can you try the attached please and let me know how
it goes?


-------------------- snip snip --------------------
Index: NewsRunner.py
RCS file: /cvsroot/mailman/mailman/Mailman/Queue/NewsRunner.py,v
retrieving revision 2.8
diff -u -r2.8 NewsRunner.py
--- NewsRunner.py	12 Oct 2001 05:16:18 -0000	2.8
+++ NewsRunner.py	26 Feb 2002 06:19:11 -0000
@@ -56,7 +56,7 @@
             prepare_message(mlist, msg, msgdata)
             # Flatten the message object, sticking it in a StringIO object
-            fp = StringIO(str(msg))
+            fp = StringIO(msg.as_string())
             conn = None