[Mailman-Developers] Can't approve/discard/reject subscriptions in 2.1a4

Brett Delmage brett@twobikes.ottawa.on.ca
Tue, 26 Feb 2002 21:00:12 -0500 (EST)

Problem: I can't clear pending subscription requests by processing them.
I applied the patch to 2.1a4 below but it doesn't work for me.

The steps to duplicate the problem are listed below and are very simple.

I created a new list.

I subscribed to the list using email, not the web form, using the list
defaults. The subscription was activated without incident.

Using Konquerer (2.2.1) as my browser, I modified the subcribe_policy to
"Require approval" then subscribed to it using a different email address.

I received the "Your subscription request has been forwarded to the  list
administrator" message as expected, as well as the list-owner

I went to the Administrative requests for mailing list: form
and confirmed that the pending subscribe request was shown.

I selected the Discard radio button end entered a reason, then the submit

I confirmed that the rejection notice was mailed to the subscriber.

However the subscriber was still shown as a subscription request.

I tried resubmitting the form with the Approve radio button selected. The
subscriber was sent a welcome message, but still appeared on the form as a
pending subscription request.

I selected the Reject radio button end entered a reason, then the submit
button. The subscriber (supposedly already subscribed!) was mailed a
rejection notice. And still appeared on the form as a pending request.
Some users just won't go away ;-)

If left in this state, the daily oustanding moderations nag is mailed to
the list owner.

I've looked at the code but am just learning python (part of my reason for
using mailman, I figured it was a great 'real world' project to help me
learn python.) But I couldn't see the problem. Maybe in a month or two...

I hope the steps to reproduce the problem are helpful. Really, you can't
help but encounter it.

Thanks to all those working on Mailman. It's a really impressive list
manager despite this bug, which doesn't affect the actual list operation
in any way.



On Thu, 24 Jan 2002, Les Niles wrote:

> (Apologies if this has already been reported.  I don't remember
> it.)  Approval of pending subscriptions via the admindb web page is
> ignored in 2.1a4.  Here's a patch that fixes this.
> -------------------------------------------------------------
> *** Mailman/Cgi/admindb.py.~1~  Sun Jan  6 23:04:02 2002
> --- Mailman/Cgi/admindb.py      Thu Jan 24 21:56:59 2002
> ***************
> *** 630,635 ****
> --- 630,636 ----
>           except ValueError:
>               continue
>           if v not in (mm_cfg.DEFER, mm_cfg.APPROVE,
> +                      mm_cfg.SUBSCRIBE, mm_cfg.UNSUBSCRIBE,
>                        mm_cfg.REJECT, mm_cfg.DISCARD):
>               continue
>           # Get the action comment and reasons if present.
> _______________________________________________
> Mailman-Developers mailing list
> Mailman-Developers@python.org
> http://mail.python.org/mailman/listinfo/mailman-developers