[Mailman-Developers] list_members doesn't return the whole membership list

[Marc MERLIN]

On Tue, Mar 05, 2002 at 11:22:55PM -0500, Barry A. Warsaw wrote:
> 
> >>>>> "MM" == Marc MERLIN <marc_news@vasoftware.com> writes:
> 
>     MM> root@gandalf:/var/local/mailman/bin# ./dumpdb
>     MM> ../lists/test3/config.pck | grep user_options 'user_options':
>     MM> {'marc@merlins.org': 266},
>     MM> root@gandalf:/var/local/mailman/bin# ./list_members test3
>     MM> root@gandalf:/var/local/mailman/bin#
> 
> That's a bug, fixed now in cvs.
 
Yeah, I saw the commit a few hours later :-)
 
>     MM> On bigger lists, list_members returns some of the list
>     MM> membership. It's not just the digest or non digest members, it
>     MM> looks kinda random.
> 
> Hmm, do a cvs update and try again.  How's it look now?

I subscribed to mailman-checkins, it's easier, I just waited to see the
commit :-)

BTW, here's a small patch on top of that:

--- list_members.mm	Wed Mar  6 13:12:19 2002
+++ list_members	Wed Mar  6 13:26:33 2002
@@ -103,11 +103,12 @@
     kind = None
 
     args = sys.argv[1:]
-    if not args:
-        usage(0)
 
     while 1:
-        opt = args.pop(0)
+	try:
+	    opt = args.pop(0)
+	except IndexError:
+	    usage(1)
         if opt in ('-h', '--help'):
             usage(0)
         elif opt in ('-p', '--preserve'):


It solves this:

moremagic.m.o:/var/local/mailman/bin# ./list_members.mm -n 
Traceback (most recent call last):
  File "./list_members.mm", line 204, in ?
    main()
  File "./list_members.mm", line 110, in main
    opt = args.pop(0)
IndexError: pop from empty list

Marc
-- 
Microsoft is to operating systems & security ....
                                      .... what McDonalds is to gourmet cooking
  
Home page: http://marc.merlins.org/   |   Finger marc_f@merlins.org for PGP key