[Mailman-Developers] Missing footers with latest CVS

Dan Mick Dan Mick <dmick@utopia.West.Sun.COM>
Tue, 12 Mar 2002 14:49:55 -0800 (PST)


> > Index: Decorate.py
> > ===================================================================
> > RCS file: /cvsroot/mailman/mailman/Mailman/Handlers/Decorate.py,v
> > retrieving revision 2.13
> > diff -u -r2.13 Decorate.py
> > --- Decorate.py	12 Mar 2002 00:49:40 -0000	2.13
> > +++ Decorate.py	12 Mar 2002 20:29:12 -0000
> > @@ -72,6 +72,7 @@
> >      # BAW: If the charsets don't match, should we add the header and footer 
by
> >      # MIME multipart chroming the message?
> >      if not msg.is_multipart() and msgtype == 'text/plain' and \
> > +           not msg.get('content-transfer-encoding').lower() == 'base64' and 
\
> >             (lcset == 'us-ascii' or mcset == lcset):
> >          payload = header + msg.get_payload() + footer
> >          msg.set_payload(payload)
> 
> That (lcset == 'us-ascii') alternative assumes that the body
> charset is always ASCII-friendly. Close, but not exactly true.

The assertion was made that *all* charsets we support have us-ascii
as a strict and complete subset.  Are you claiming that's not true,
or claiming that the assertion isn't sufficient to allow that
alternative?