[Mailman-Developers] timeout error with mail processing??

Fil fil@rezo.net
Fri, 15 Mar 2002 18:50:47 +0100


Shouldn't it rather be implemented inside ParseMailCommands()?

>     F> I'm confident you should not raise a TimeOutError when
>     F> processing email: it times out, just requeue the mail for
>     F> processing another time...

> Index: CommandRunner.py
> ===================================================================
> RCS file: /cvsroot/mailman/mailman/Mailman/Queue/CommandRunner.py,v
> retrieving revision 2.11
> diff -u -u -r2.11 CommandRunner.py
> --- CommandRunner.py	14 Mar 2002 05:02:30 -0000	2.11
> +++ CommandRunner.py	15 Mar 2002 17:36:51 -0000
> @@ -67,7 +67,12 @@
>                  del msg['subject']
>                  msg['Subject'] = 'leave'
>                  msg.set_payload('')
> -                mlist.ParseMailCommands(msg, msgdata)
> +                try:
> +                    mlist.ParseMailCommands(msg, msgdata)
> +                except LockFile.TimeOutError:
> +                    # We probably could not get the lock on the pending
> +                    # database.  That's okay, we'll just try again later.
> +                    return 1
>              elif msgdata.get('toconfirm'):
>                  mo = re.match(mm_cfg.VERP_CONFIRM_REGEXP, msg.get('to', ''))
>                  if mo:

-- Fil