[Mailman-Developers] [ mailman-Patches-567288 ] 'rejection-notice' breaks METAFMT_ASCII

[noreply@sourceforge.net]

Patches item #567288, was opened at 2002-06-11 03:13
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=567288&group_id=103

Category: mail delivery
Group: Mailman 2.1
>Status: Closed
>Resolution: Accepted
Priority: 7
Submitted By: Maximillian Dornseif (mdornseif)
Assigned to: Nobody/Anonymous (nobody)
Summary: 'rejection-notice' breaks METAFMT_ASCII

Initial Comment:
The variable 'rejection-notice' will not work well with
METADATA_FORMAT = METAFMT_ASCII or HOLD_MESSAGES_AS_PICKLES = 0.
Renaming to 'rejection_notice' helps.

I guess this change breaks kompatibility with old queues.

In case SF.net upload breaks:
http://c0re.jp/c0de/misc/mailman-2.1b2-rejection-notice.patch

Index: ./Mailman/Cgi/admindb.py
-                 text = Utils.wrap(msgdata.get('rejection-notice',
+                 text = Utils.wrap(msgdata.get('rejection_notice',
Index: ./Mailman/Handlers/Hold.py
-    msgdata['rejection-notice'] = Utils.wrap(exc.rejection_notice(mlist))
+    msgdata['rejection_notice'] = Utils.wrap(exc.rejection_notice(mlist))


----------------------------------------------------------------------

>Comment By: Barry A. Warsaw (bwarsaw)
Date: 2002-11-18 20:05

Message:
Logged In: YES 
user_id=12800

Note that while I don't think HOLD_MESSAGES_AS_PICKLES is
affected, you're right about METADATA_FORMAT= METAFMT_ASCII.
 This is because that format uses execfile() and dashes
aren't allowed in identifiers. 

Fixed, thanks.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=567288&group_id=103