[Mailman-Developers] error with bad email with % in addErrorin htmlformat.py

[Brad Knowles]

At 9:39 AM +0100 2005-01-11, Brad Knowles wrote:

>  	There needs to be another way to solve this problem.

	I got a private reply with an alternative solution to this 
problem.  With permission, I am including it here:

Subject: RE: [Mailman-Developers] error with bad email with % in 
addErrorin	htmlformat.py
Date: Tue, 11 Jan 2005 10:10:07 -0500
From: "Mike Sandler" <msandler at HostMySite.com>
To: "Brad Knowles" <brad at stop.mail-abuse.org>

I believe that it is a probably a good idea to fix the htmlformat.py
addError to accept empty args. I have never programmed python before - I
hacked a solution.

I was the one that was afflicted with the problem.  I "fixed" the
problem by changing htmlformat.py around line 340 to:
     def addError(self, errmsg, tag=None, *args):
         if tag is None:
             tag = _('Error: ')
         if args is not ():
            self.AddItem(Header(3, Bold(FontAttr(
                _(tag), color=mm_cfg.WEB_ERROR_COLOR,
size='+2')).Format() +
                             Italic(errmsg % args ).Format()))
         else:
                 self.AddItem(Header(3, Bold(FontAttr(
                         _(tag), color=mm_cfg.WEB_ERROR_COLOR,
size='+2')).Format() +
                             Italic(errmsg).Format()))

-- 
Brad Knowles, <brad at stop.mail-abuse.org>

"Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety."

     -- Benjamin Franklin (1706-1790), reply of the Pennsylvania
     Assembly to the Governor, November 11, 1755

   SAGE member since 1995.  See <http://www.sage.org/> for more info.