[Mailman-Developers] error with bad email with % in addErrorin htmlformat.py

Tokio Kikuchi tkikuchi at is.kochi-u.ac.jp
Wed Jan 12 03:25:44 CET 2005


>>I was the one that was afflicted with the problem.  I "fixed" the
>>problem by changing htmlformat.py around line 340 to:
>>    def addError(self, errmsg, tag=None, *args):
>>        if tag is None:
>>            tag = _('Error: ')
>>        if args is not ():
>>           self.AddItem(Header(3, Bold(FontAttr(
>>               _(tag), color=mm_cfg.WEB_ERROR_COLOR,
>>size='+2')).Format() +
>>                            Italic(errmsg % args ).Format()))
>>        else:
>>                self.AddItem(Header(3, Bold(FontAttr(
>>                        _(tag), color=mm_cfg.WEB_ERROR_COLOR,
>>size='+2')).Format() +
>>                            Italic(errmsg).Format()))

This fix is right direction. I confirmed 'args' is no longer used by 
find-and-grepping the source files and removed  '% args' finally. The 
variable insert is now done by i18n._().

Thank you all for this fix is just in time for 2.1.6 release.

> Tokio's last post in this thread seemed to indicate he has a handle on
> the cause and presumably the cure.
Tokio Kikuchi, tkikuchi@ is.kochi-u.ac.jp

More information about the Mailman-Developers mailing list