[Mailman-Developers] [Mailman-checkins] SF.net SVN: mailman: [8090] trunk/mailman/Mailman

[Barry Warsaw]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Nov 8, 2006, at 8:14 PM, tkikuchi at users.sourceforge.net wrote:

> Revision: 8090
>           http://svn.sourceforge.net/mailman/?rev=8090&view=rev
> Author:   tkikuchi
> Date:     2006-11-08 17:13:59 -0800 (Wed, 08 Nov 2006)
>
> Log Message:
> -----------
> MailList.py ... GetScriptURL() absolute again because we need it  
> for email
>                 notifications.
> wsgi_app.py ... URI normalization by stripping trailing slash.  We  
> need
>                 Special care for 'private'.
> 		Strip dot only components in the PATH_INFO for sanitization.

Hi Tokio,

I'm not so sure about this change.  It breaks the ability to access  
the web page urls by both the wsgi path and the apache ScriptAlias  
path at the same time.  I've tried to make sure that worked because  
it's pretty useful for debugging.

I'm trying to keep the principle that all internal web page urls are  
relative, which is why we currently try to figure out the prefix to  
the script and then reproduce that in the cookie path (see  
SecurityManager.py).  I've also been thinking about trying to get rid  
of mlist.web_page_url (I don't much like hard coding that in the  
list's data).

I understand that we'll need absolute paths in the email  
notifications, and I've read the note about not exposing wsgi_app  
interface to the internet.  I'm not sure I agree with the latter  
though, and besides, I'd like us to be as flexible as possible for  
wsgi integration.  I think we should try to find some other way to do  
the email notification urls and keep GetScriptURL() returning  
relative paths.

E.g. when I try to use r8090 via the Apache ScriptAlias path, I end  
up getting three slashes between the host and the 'mailman' prefix.

- -Barry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iQCVAwUBRVaCEXEjvBPtnXfVAQIOIQP8DTdlILSlUli9+WgSdskfl2+i44ON3gvx
0uoEZZ1lPon6NgJFg5Y3BCAr7YLAXsrj4pyXrhAxxLomgnjt6eM9BKdIWkSmZMl9
smQ/En31Xs5tKd69jtekaiMNMy4kMx0Yo53ci0E7yp6tVkpIh05Vg0wAB/wQr71Y
6etMJUeeJ78=
=gFtd
-----END PGP SIGNATURE-----