[Mailman-Developers] [Mailman-checkins] SF.net SVN: mailman: [8181] trunk/mailman/Mailman

[Barry Warsaw]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Tokio,

Thanks for the patches, and especially the test cases!  I have a  
couple of questions for you.

I noticed that current trunk is failing three tests:

test_no_multipart_mixed_charset
test_scrub_image
test_scrub_text

Can you check to see if those are failing for you?

Also I was wondering about the latest change to passwords.py:

On Mar 24, 2007, at 10:57 PM, tkikuchi at users.sourceforge.net wrote:

> Modified: trunk/mailman/Mailman/passwords.py
> ===================================================================
> --- trunk/mailman/Mailman/passwords.py	2007-03-24 06:01:35 UTC (rev  
> 8180)
> +++ trunk/mailman/Mailman/passwords.py	2007-03-25 02:57:18 UTC (rev  
> 8181)
> @@ -240,6 +240,9 @@
>      scheme       = scheme_parts[0].lower()
>      scheme_enum  = _SCHEMES_BY_TAG.get(scheme, _DEFAULT_SCHEME)
>      scheme_class = _SCHEMES_BY_ENUM[scheme_enum]
> +    if isinstance(rest_group, unicode):
> +        # decode() fails. (challenge is from database)
> +        rest_group = str(rest_group)
>      return scheme_class.check_response(rest_group, response,  
> *scheme_parts[1:])

Earlier, I was using s.encode('utf-8') to ensure that we had an 8-bit  
string for the hash function.  I'm wondering if you prefer str()  
over .encode('utf-8') here and if so, what the reason is?

Cheers,
- -Barry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iQCVAwUBRghtRXEjvBPtnXfVAQJAXQP/enWB9iOvVDJ6B+k3ggN32EjszSH4XvKU
lY9A6gomMIdE+gIivNtbBx6ziv6w2AvYkV2fBC3sc5ooyZGQesjl5gpeZ53AwCyF
HF9bVQuW72L9TxvWIYOO+wnADr97YyYSU/rNHT7GPua5Z+1SnwF5FQknFtpVFZdO
yqzwK5b5C5E=
=moCg
-----END PGP SIGNATURE-----