[Mailman-Developers] [PATCH] for the notorious Sender header

Mark Sapiro mark at msapiro.net
Wed Jun 30 16:55:38 CEST 2010

Malte S. Stretzwrote:
>Here is a branch for 2.1:
>  https://code.launchpad.net/~mss/mailman/2.1-sender-header
>And here for 2.2:
>  https://code.launchpad.net/~mss/mailman/2.2-sender-header
>Not sure how to proceed from here, shall I try a merge proposal?

I looked at your patch yesterday. It seems good, but it's missing a
critical piece. It has to increment DATA_FILE_VERSION in
Mailman/Version.py. Otherwise, the code in Mailman/versions.py to add
the include_sender_header attribute to existing lists will not be
called. See the CheckVersion() method in Mailman/MailList.py.

I don't have a problem with including the patch in 2.1, except for the


If it were no, the feature would be entirely transparent to those who
didn't want it, essentially preserving the current situation for those
who took no action.

The problem with that is all those cPanel and service provider list
owners who would then not have access to the feature even if they were
aware and wanted it, so I think the default needs to be Yes which is
somewhat disruptive, but probably not excessively so considering the
potential benefit.

Mark Sapiro <mark at msapiro.net>        The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan

More information about the Mailman-Developers mailing list