[Mailman-Developers] Mailman-Developers Digest, Vol 274, Issue 12
Jagannathan Tiruvallur Eachambadi
jagannathante at gmail.com
Mon Feb 20 19:52:06 CET 2012
I copied the folder mailmanweb/src/mailman-django to django_dev_setup/ and
the server works. But it does not go through all tests. This is snippet of
the errors in the test. http://pastebin.com/1CrKWpkp .
On Mon, Feb 20, 2012 at 10:14 PM, <mailman-developers-request at python.org>wrote:
> Send Mailman-Developers mailing list submissions to
> mailman-developers at python.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://mail.python.org/mailman/listinfo/mailman-developers
> or, via email, send a message with subject or body 'help' to
> mailman-developers-request at python.org
>
> You can reach the person managing the list at
> mailman-developers-owner at python.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Mailman-Developers digest..."
>
>
> Today's Topics:
>
> 1. GSOC 12 (Jagannathan Tiruvallur Eachambadi)
> 2. Re: GSOC 12 (Jagannathan Tiruvallur Eachambadi)
> 3. Re: GSOC 12 (Florian Fuchs)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Mon, 20 Feb 2012 16:10:52 +0530
> From: Jagannathan Tiruvallur Eachambadi <jagannathante at gmail.com>
> To: mailman-developers at python.org
> Subject: [Mailman-Developers] GSOC 12
> Message-ID:
> <CABzJUX6EYs2RX7w60nHKgpRpJ33XMA3A6dLMkSjHvVr33mZvYg at mail.gmail.com
> >
> Content-Type: text/plain; charset=ISO-8859-1
>
> hi all,
>
> I am currently doing my first year of under-graduation in NIT-Trichy.
> I was reading the GSOC 12 getting started page and I am unable to to get
> the Django server working. I get ERNO 111 , I tried shutting down apache in
> my computer. But that did not solve the problem. I get the following error,
> http://dpaste.com/705607/ .
>
> On Sun, Feb 19, 2012 at 4:30 PM, <mailman-developers-request at python.org
> >wrote:
>
> > Send Mailman-Developers mailing list submissions to
> > mailman-developers at python.org
> >
> > To subscribe or unsubscribe via the World Wide Web, visit
> > http://mail.python.org/mailman/listinfo/mailman-developers
> > or, via email, send a message with subject or body 'help' to
> > mailman-developers-request at python.org
> >
> > You can reach the person managing the list at
> > mailman-developers-owner at python.org
> >
> > When replying, please edit your Subject line so it is more specific
> > than "Re: Contents of Mailman-Developers digest..."
> >
> >
> > Today's Topics:
> >
> > 1. Re: Probe messages should not sent Precedenceheader (Mark
> > Sapiro)
> > 2. Re: Probe messages should not sent Precedenceheader (Aamir
> > Khan)
> > 3. Re: Probe messages should not sent Precedenceheader (Mark
> > Sapiro)
> >
> >
> > ----------------------------------------------------------------------
> >
> > Message: 1
> > Date: Sat, 18 Feb 2012 09:22:53 -0800
> > From: Mark Sapiro <mark at msapiro.net>
> > To: Aamir Khan <syst3m.w0rm at gmail.com>
> > Cc: Mailman-Developers at python.org
> > Subject: Re: [Mailman-Developers] Probe messages should not sent
> > Precedenceheader
> > Message-ID: <PC195201202180922530437aace67aa at MSAPIRO>
> > Content-Type: text/plain; charset=iso-8859-1
> >
> > Aamir Khan wrote:
> >
> > >I guess in MM3, there is no function as sendNextNotification(), because
> i
> > >used command, "grep sendNextNotification() -r *" and the result was only
> > >file 'src/mailman/bin/disabled.py'.
> >
> >
> > Which means that bin/disabled.py won't work because it hasn't been
> > fully converted from 2.1 yet. It should be using the send_probe()
> > function instead of sendNextNotification().
> >
> >
> > >There is a file 'src/mailman/email/messages.py', in which
> > >UserNotification() class is defined. It has a send function, which sets
> > the
> > >precedence header.
> > >
> > >In file 'src/mailman/app/bouces.py', I guess the probe messages are sent
> > >directly using send() function of UserNotification() class. I think that
> > >from line 211 to 228, probe message is used to send VERP probe. But
> then,
> > i
> > >am not able to find out the place from where probe message is sent after
> > >disabling of the address because of over bouncing.
> >
> >
> > There should be two places. bin/disabled.py should be calling
> > send_probe() instead of the non-existent sendNextNotification() list
> > method.
> >
> > Also, send_probe() should be called when delivery is initially disabled
> > as a result of a call to IBounceProcessor(), but I am unable to follow
> > how this works or even if it is implemented yet at least in part
> > because I haven't yet learned anything about how things like
> > zope.component.getUtility() work.
> >
> >
> > >I have tried to make some changes to code and pushed it to my local
> branch
> > >[1]. Ran through all the tests, and none of them failed. Is there any
> way
> > >to run through a subset of test rather than running them using
> 'bin/test'
> > >command.
> > >
> > >Comments, feedback required on patch.
> > >
> > >
> > >[1] =>
> > >
> http://bazaar.launchpad.net/~syst3mw0rm/mailman/precedence/revision/7080
> >
> >
> > The patch itself looks good except for style. We normally don't put
> > whitespace around the = in keyword=value arguments in definitions and
> > calls. PEP 8 <http://www.python.org/dev/peps/pep-0008/> says "Don't
> > use spaces around the '=' sign when used to indicate a keyword
> > argument or a default parameter value."
> >
> > --
> > Mark Sapiro <mark at msapiro.net> The highway is for gamblers,
> > San Francisco Bay Area, California better use your sense - B. Dylan
> >
> >
> >
> > ------------------------------
> >
> > Message: 2
> > Date: Sat, 18 Feb 2012 23:16:37 +0530
> > From: Aamir Khan <syst3m.w0rm at gmail.com>
> > To: Mark Sapiro <mark at msapiro.net>
> > Cc: Mailman-Developers at python.org
> > Subject: Re: [Mailman-Developers] Probe messages should not sent
> > Precedenceheader
> > Message-ID:
> > <
> CAOb12VXRgZGMcO6W2GADwVOczHOW1zTF3xduZfoWHh_-T4BLWg at mail.gmail.com
> > >
> > Content-Type: text/plain; charset=ISO-8859-1
> >
> > Mark Sapiro <mark at msapiro.net> wrote:
> >
> > >
> > > Which means that bin/disabled.py won't work because it hasn't been
> > > fully converted from 2.1 yet. It should be using the send_probe()
> > > function instead of sendNextNotification().
> > >
> >
> > Yes. I also think so. I have changed the function to send_probe() and ran
> > through all the test again to make sure that nothing breaks.
> >
> >
> > >
> > > There should be two places. bin/disabled.py should be calling
> > > send_probe() instead of the non-existent sendNextNotification() list
> > > method.
> > >
> > > Also, send_probe() should be called when delivery is initially disabled
> > > as a result of a call to IBounceProcessor(), but I am unable to follow
> > > how this works or even if it is implemented yet at least in part
> > > because I haven't yet learned anything about how things like
> > > zope.component.getUtility() work.
> > >
> >
> > I am also not able to find out the relevant code, as i am completely new
> to
> > the flow of how mailman works. Maybe, barry can help me on this one.
> >
> > >
> > >
> > > The patch itself looks good except for style. We normally don't put
> > > whitespace around the = in keyword=value arguments in definitions and
> > > calls. PEP 8 <http://www.python.org/dev/peps/pep-0008/> says "Don't
> > > use spaces around the '=' sign when used to indicate a keyword
> > > argument or a default parameter value."
> > >
> > > I will keep this in mind. I have created another branch with partial
> > changes suggested above. Here, you can find the changes,
> >
> > http://bazaar.launchpad.net/~syst3mw0rm/mailman/808821/revision/7080
> >
> >
> >
> > --
> > Aamir Khan | 3rd Year | Computer Science & Engineering | IIT Roorkee
> >
> >
> > ------------------------------
> >
> > Message: 3
> > Date: Sat, 18 Feb 2012 10:45:28 -0800
> > From: Mark Sapiro <mark at msapiro.net>
> > To: Aamir Khan <syst3m.w0rm at gmail.com>
> > Cc: Mailman-Developers at python.org
> > Subject: Re: [Mailman-Developers] Probe messages should not sent
> > Precedenceheader
> > Message-ID: <PC195201202181045280109fb8c76c9 at MSAPIRO>
> > Content-Type: text/plain; charset=iso-8859-1
> >
> > Aamir Khan wrote:
> > >
> > >Mark Sapiro <mark at msapiro.net> wrote:
> > >
> > >>
> > >> Which means that bin/disabled.py won't work because it hasn't been
> > >> fully converted from 2.1 yet. It should be using the send_probe()
> > >> function instead of sendNextNotification().
> > >>
> > >
> > >Yes. I also think so. I have changed the function to send_probe() and
> ran
> > >through all the test again to make sure that nothing breaks.
> >
> >
> > I don't think you can simply change mlist.sendNextNotification(member)
> > to mlist.send_probe(member) because send_probe() is not a list method,
> > plus it requires a message argument in addition to the member argument.
> >
> > Also, it is apparent that the test suite is not testing bin/disabled.py
> > or it would have been failing all along.
> >
> > --
> > Mark Sapiro <mark at msapiro.net> The highway is for gamblers,
> > San Francisco Bay Area, California better use your sense - B. Dylan
> >
> >
> >
> > ------------------------------
> >
> > _______________________________________________
> > Mailman-Developers mailing list
> > Mailman-Developers at python.org
> > http://mail.python.org/mailman/listinfo/mailman-developers
> >
> >
> > End of Mailman-Developers Digest, Vol 274, Issue 10
> > ***************************************************
> >
>
>
> ------------------------------
>
> Message: 2
> Date: Mon, 20 Feb 2012 16:20:11 +0530
> From: Jagannathan Tiruvallur Eachambadi <jagannathante at gmail.com>
> To: mailman-developers at python.org
> Subject: Re: [Mailman-Developers] GSOC 12
> Message-ID:
> <CABzJUX4yLEAfnPg_EzCc9dQuNbYUDSLPwbG1ZT4vim1cTj3T6w at mail.gmail.com
> >
> Content-Type: text/plain; charset=ISO-8859-1
>
> Sorry, the error is TemplateDoesNotExist. I forgot to start the mailman
> runner. This is the error I am getting : http://dpaste.com/705614/
>
> On Mon, Feb 20, 2012 at 4:10 PM, Jagannathan Tiruvallur Eachambadi <
> jagannathante at gmail.com> wrote:
>
> >
> > hi all,
> >
> > I am currently doing my first year of under-graduation in
> NIT-Trichy.
> > I was reading the GSOC 12 getting started page and I am unable to to get
> > the Django server working. I get ERNO 111 , I tried shutting down apache
> in
> > my computer. But that did not solve the problem. I get the following
> error,
> > http://dpaste.com/705607/ .
> >
> > On Sun, Feb 19, 2012 at 4:30 PM, <mailman-developers-request at python.org
> >wrote:
> >
> >> Send Mailman-Developers mailing list submissions to
> >> mailman-developers at python.org
> >>
> >> To subscribe or unsubscribe via the World Wide Web, visit
> >> http://mail.python.org/mailman/listinfo/mailman-developers
> >> or, via email, send a message with subject or body 'help' to
> >> mailman-developers-request at python.org
> >>
> >> You can reach the person managing the list at
> >> mailman-developers-owner at python.org
> >>
> >> When replying, please edit your Subject line so it is more specific
> >> than "Re: Contents of Mailman-Developers digest..."
> >>
> >>
> >> Today's Topics:
> >>
> >> 1. Re: Probe messages should not sent Precedenceheader (Mark
> >> Sapiro)
> >> 2. Re: Probe messages should not sent Precedenceheader (Aamir
> >> Khan)
> >> 3. Re: Probe messages should not sent Precedenceheader (Mark
> >> Sapiro)
> >>
> >>
> >> ----------------------------------------------------------------------
> >>
> >> Message: 1
> >> Date: Sat, 18 Feb 2012 09:22:53 -0800
> >> From: Mark Sapiro <mark at msapiro.net>
> >> To: Aamir Khan <syst3m.w0rm at gmail.com>
> >> Cc: Mailman-Developers at python.org
> >> Subject: Re: [Mailman-Developers] Probe messages should not sent
> >> Precedenceheader
> >> Message-ID: <PC195201202180922530437aace67aa at MSAPIRO>
> >> Content-Type: text/plain; charset=iso-8859-1
> >>
> >> Aamir Khan wrote:
> >>
> >> >I guess in MM3, there is no function as sendNextNotification(),
> because i
> >> >used command, "grep sendNextNotification() -r *" and the result was
> only
> >> >file 'src/mailman/bin/disabled.py'.
> >>
> >>
> >> Which means that bin/disabled.py won't work because it hasn't been
> >> fully converted from 2.1 yet. It should be using the send_probe()
> >> function instead of sendNextNotification().
> >>
> >>
> >> >There is a file 'src/mailman/email/messages.py', in which
> >> >UserNotification() class is defined. It has a send function, which sets
> >> the
> >> >precedence header.
> >> >
> >> >In file 'src/mailman/app/bouces.py', I guess the probe messages are
> sent
> >> >directly using send() function of UserNotification() class. I think
> that
> >> >from line 211 to 228, probe message is used to send VERP probe. But
> >> then, i
> >> >am not able to find out the place from where probe message is sent
> after
> >> >disabling of the address because of over bouncing.
> >>
> >>
> >> There should be two places. bin/disabled.py should be calling
> >> send_probe() instead of the non-existent sendNextNotification() list
> >> method.
> >>
> >> Also, send_probe() should be called when delivery is initially disabled
> >> as a result of a call to IBounceProcessor(), but I am unable to follow
> >> how this works or even if it is implemented yet at least in part
> >> because I haven't yet learned anything about how things like
> >> zope.component.getUtility() work.
> >>
> >>
> >> >I have tried to make some changes to code and pushed it to my local
> >> branch
> >> >[1]. Ran through all the tests, and none of them failed. Is there any
> way
> >> >to run through a subset of test rather than running them using
> 'bin/test'
> >> >command.
> >> >
> >> >Comments, feedback required on patch.
> >> >
> >> >
> >> >[1] =>
> >> >
> http://bazaar.launchpad.net/~syst3mw0rm/mailman/precedence/revision/7080
> >>
> >>
> >> The patch itself looks good except for style. We normally don't put
> >> whitespace around the = in keyword=value arguments in definitions and
> >> calls. PEP 8 <http://www.python.org/dev/peps/pep-0008/> says "Don't
> >> use spaces around the '=' sign when used to indicate a keyword
> >> argument or a default parameter value."
> >>
> >> --
> >> Mark Sapiro <mark at msapiro.net> The highway is for gamblers,
> >> San Francisco Bay Area, California better use your sense - B. Dylan
> >>
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 2
> >> Date: Sat, 18 Feb 2012 23:16:37 +0530
> >> From: Aamir Khan <syst3m.w0rm at gmail.com>
> >> To: Mark Sapiro <mark at msapiro.net>
> >> Cc: Mailman-Developers at python.org
> >> Subject: Re: [Mailman-Developers] Probe messages should not sent
> >> Precedenceheader
> >> Message-ID:
> >> <
> >> CAOb12VXRgZGMcO6W2GADwVOczHOW1zTF3xduZfoWHh_-T4BLWg at mail.gmail.com>
> >> Content-Type: text/plain; charset=ISO-8859-1
> >>
> >> Mark Sapiro <mark at msapiro.net> wrote:
> >>
> >> >
> >> > Which means that bin/disabled.py won't work because it hasn't been
> >> > fully converted from 2.1 yet. It should be using the send_probe()
> >> > function instead of sendNextNotification().
> >> >
> >>
> >> Yes. I also think so. I have changed the function to send_probe() and
> ran
> >> through all the test again to make sure that nothing breaks.
> >>
> >>
> >> >
> >> > There should be two places. bin/disabled.py should be calling
> >> > send_probe() instead of the non-existent sendNextNotification() list
> >> > method.
> >> >
> >> > Also, send_probe() should be called when delivery is initially
> disabled
> >> > as a result of a call to IBounceProcessor(), but I am unable to follow
> >> > how this works or even if it is implemented yet at least in part
> >> > because I haven't yet learned anything about how things like
> >> > zope.component.getUtility() work.
> >> >
> >>
> >> I am also not able to find out the relevant code, as i am completely new
> >> to
> >> the flow of how mailman works. Maybe, barry can help me on this one.
> >>
> >> >
> >> >
> >> > The patch itself looks good except for style. We normally don't put
> >> > whitespace around the = in keyword=value arguments in definitions and
> >> > calls. PEP 8 <http://www.python.org/dev/peps/pep-0008/> says "Don't
> >> > use spaces around the '=' sign when used to indicate a keyword
> >> > argument or a default parameter value."
> >> >
> >> > I will keep this in mind. I have created another branch with partial
> >> changes suggested above. Here, you can find the changes,
> >>
> >> http://bazaar.launchpad.net/~syst3mw0rm/mailman/808821/revision/7080
> >>
> >>
> >>
> >> --
> >> Aamir Khan | 3rd Year | Computer Science & Engineering | IIT Roorkee
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 3
> >> Date: Sat, 18 Feb 2012 10:45:28 -0800
> >> From: Mark Sapiro <mark at msapiro.net>
> >> To: Aamir Khan <syst3m.w0rm at gmail.com>
> >> Cc: Mailman-Developers at python.org
> >> Subject: Re: [Mailman-Developers] Probe messages should not sent
> >> Precedenceheader
> >> Message-ID: <PC195201202181045280109fb8c76c9 at MSAPIRO>
> >> Content-Type: text/plain; charset=iso-8859-1
> >>
> >> Aamir Khan wrote:
> >> >
> >> >Mark Sapiro <mark at msapiro.net> wrote:
> >> >
> >> >>
> >> >> Which means that bin/disabled.py won't work because it hasn't been
> >> >> fully converted from 2.1 yet. It should be using the send_probe()
> >> >> function instead of sendNextNotification().
> >> >>
> >> >
> >> >Yes. I also think so. I have changed the function to send_probe() and
> ran
> >> >through all the test again to make sure that nothing breaks.
> >>
> >>
> >> I don't think you can simply change mlist.sendNextNotification(member)
> >> to mlist.send_probe(member) because send_probe() is not a list method,
> >> plus it requires a message argument in addition to the member argument.
> >>
> >> Also, it is apparent that the test suite is not testing bin/disabled.py
> >> or it would have been failing all along.
> >>
> >> --
> >> Mark Sapiro <mark at msapiro.net> The highway is for gamblers,
> >> San Francisco Bay Area, California better use your sense - B. Dylan
> >>
> >>
> >>
> >> ------------------------------
> >>
> >> _______________________________________________
> >> Mailman-Developers mailing list
> >> Mailman-Developers at python.org
> >> http://mail.python.org/mailman/listinfo/mailman-developers
> >>
> >>
> >> End of Mailman-Developers Digest, Vol 274, Issue 10
> >> ***************************************************
> >>
> >
> >
>
>
> ------------------------------
>
> Message: 3
> Date: Mon, 20 Feb 2012 17:43:47 +0100
> From: "Florian Fuchs" <f at state-of-mind.de>
> To: "Jagannathan Tiruvallur Eachambadi" <jagannathante at gmail.com>
> Cc: mailman-developers at python.org
> Subject: Re: [Mailman-Developers] GSOC 12
> Message-ID: <1f3e-4f427880-7-13fbcde0 at 263897354>
> Content-Type: text/plain; charset="utf-8"
>
> Hi Jagannathan,
>
> if the Error is TemplateDoesNotExist, the first thing to check would be:
> Does the relevant file exist and does the user starting the server have the
> necessary rights to access it?
>
> In your case that would be the following file:
>
>
> <folder-where-mailmanweb-lives>/mailmanweb/src/mailman_django/templates/mailman-django/lists/index.html
>
> Any luck?
>
> Florian
>
>
>
> On Monday, February 20, 2012 11:50 CET, Jagannathan Tiruvallur Eachambadi <
> jagannathante at gmail.com> wrote:
>
> > Sorry, the error is TemplateDoesNotExist. I forgot to start the mailman
> > runner. This is the error I am getting : http://dpaste.com/705614/
> >
> > On Mon, Feb 20, 2012 at 4:10 PM, Jagannathan Tiruvallur Eachambadi <
> > jagannathante at gmail.com> wrote:
> >
> > >
> > > hi all,
> > >
> > > I am currently doing my first year of under-graduation in
> NIT-Trichy.
> > > I was reading the GSOC 12 getting started page and I am unable to to
> get
> > > the Django server working. I get ERNO 111 , I tried shutting down
> apache in
> > > my computer. But that did not solve the problem. I get the following
> error,
> > > http://dpaste.com/705607/ .
> > >
> > > On Sun, Feb 19, 2012 at 4:30 PM, <
> mailman-developers-request at python.org>wrote:
> > >
> > >> Send Mailman-Developers mailing list submissions to
> > >> mailman-developers at python.org
> > >>
> > >> To subscribe or unsubscribe via the World Wide Web, visit
> > >> http://mail.python.org/mailman/listinfo/mailman-developers
> > >> or, via email, send a message with subject or body 'help' to
> > >> mailman-developers-request at python.org
> > >>
> > >> You can reach the person managing the list at
> > >> mailman-developers-owner at python.org
> > >>
> > >> When replying, please edit your Subject line so it is more specific
> > >> than "Re: Contents of Mailman-Developers digest..."
> > >>
> > >>
> > >> Today's Topics:
> > >>
> > >> 1. Re: Probe messages should not sent Precedenceheader (Mark
> > >> Sapiro)
> > >> 2. Re: Probe messages should not sent Precedenceheader (Aamir
> > >> Khan)
> > >> 3. Re: Probe messages should not sent Precedenceheader (Mark
> > >> Sapiro)
> > >>
> > >>
> > >> ----------------------------------------------------------------------
> > >>
> > >> Message: 1
> > >> Date: Sat, 18 Feb 2012 09:22:53 -0800
> > >> From: Mark Sapiro <mark at msapiro.net>
> > >> To: Aamir Khan <syst3m.w0rm at gmail.com>
> > >> Cc: Mailman-Developers at python.org
> > >> Subject: Re: [Mailman-Developers] Probe messages should not sent
> > >> Precedenceheader
> > >> Message-ID: <PC195201202180922530437aace67aa at MSAPIRO>
> > >> Content-Type: text/plain; charset=iso-8859-1
> > >>
> > >> Aamir Khan wrote:
> > >>
> > >> >I guess in MM3, there is no function as sendNextNotification(),
> because i
> > >> >used command, "grep sendNextNotification() -r *" and the result was
> only
> > >> >file 'src/mailman/bin/disabled.py'.
> > >>
> > >>
> > >> Which means that bin/disabled.py won't work because it hasn't been
> > >> fully converted from 2.1 yet. It should be using the send_probe()
> > >> function instead of sendNextNotification().
> > >>
> > >>
> > >> >There is a file 'src/mailman/email/messages.py', in which
> > >> >UserNotification() class is defined. It has a send function, which
> sets
> > >> the
> > >> >precedence header.
> > >> >
> > >> >In file 'src/mailman/app/bouces.py', I guess the probe messages are
> sent
> > >> >directly using send() function of UserNotification() class. I think
> that
> > >> >from line 211 to 228, probe message is used to send VERP probe. But
> > >> then, i
> > >> >am not able to find out the place from where probe message is sent
> after
> > >> >disabling of the address because of over bouncing.
> > >>
> > >>
> > >> There should be two places. bin/disabled.py should be calling
> > >> send_probe() instead of the non-existent sendNextNotification() list
> > >> method.
> > >>
> > >> Also, send_probe() should be called when delivery is initially
> disabled
> > >> as a result of a call to IBounceProcessor(), but I am unable to follow
> > >> how this works or even if it is implemented yet at least in part
> > >> because I haven't yet learned anything about how things like
> > >> zope.component.getUtility() work.
> > >>
> > >>
> > >> >I have tried to make some changes to code and pushed it to my local
> > >> branch
> > >> >[1]. Ran through all the tests, and none of them failed. Is there
> any way
> > >> >to run through a subset of test rather than running them using
> 'bin/test'
> > >> >command.
> > >> >
> > >> >Comments, feedback required on patch.
> > >> >
> > >> >
> > >> >[1] =>
> > >> >
> http://bazaar.launchpad.net/~syst3mw0rm/mailman/precedence/revision/7080
> > >>
> > >>
> > >> The patch itself looks good except for style. We normally don't put
> > >> whitespace around the = in keyword=value arguments in definitions and
> > >> calls. PEP 8 <http://www.python.org/dev/peps/pep-0008/> says "Don't
> > >> use spaces around the '=' sign when used to indicate a keyword
> > >> argument or a default parameter value."
> > >>
> > >> --
> > >> Mark Sapiro <mark at msapiro.net> The highway is for gamblers,
> > >> San Francisco Bay Area, California better use your sense - B. Dylan
> > >>
> > >>
> > >>
> > >> ------------------------------
> > >>
> > >> Message: 2
> > >> Date: Sat, 18 Feb 2012 23:16:37 +0530
> > >> From: Aamir Khan <syst3m.w0rm at gmail.com>
> > >> To: Mark Sapiro <mark at msapiro.net>
> > >> Cc: Mailman-Developers at python.org
> > >> Subject: Re: [Mailman-Developers] Probe messages should not sent
> > >> Precedenceheader
> > >> Message-ID:
> > >> <
> > >> CAOb12VXRgZGMcO6W2GADwVOczHOW1zTF3xduZfoWHh_-T4BLWg at mail.gmail.com>
> > >> Content-Type: text/plain; charset=ISO-8859-1
> > >>
> > >> Mark Sapiro <mark at msapiro.net> wrote:
> > >>
> > >> >
> > >> > Which means that bin/disabled.py won't work because it hasn't been
> > >> > fully converted from 2.1 yet. It should be using the send_probe()
> > >> > function instead of sendNextNotification().
> > >> >
> > >>
> > >> Yes. I also think so. I have changed the function to send_probe() and
> ran
> > >> through all the test again to make sure that nothing breaks.
> > >>
> > >>
> > >> >
> > >> > There should be two places. bin/disabled.py should be calling
> > >> > send_probe() instead of the non-existent sendNextNotification() list
> > >> > method.
> > >> >
> > >> > Also, send_probe() should be called when delivery is initially
> disabled
> > >> > as a result of a call to IBounceProcessor(), but I am unable to
> follow
> > >> > how this works or even if it is implemented yet at least in part
> > >> > because I haven't yet learned anything about how things like
> > >> > zope.component.getUtility() work.
> > >> >
> > >>
> > >> I am also not able to find out the relevant code, as i am completely
> new
> > >> to
> > >> the flow of how mailman works. Maybe, barry can help me on this one.
> > >>
> > >> >
> > >> >
> > >> > The patch itself looks good except for style. We normally don't put
> > >> > whitespace around the = in keyword=value arguments in definitions
> and
> > >> > calls. PEP 8 <http://www.python.org/dev/peps/pep-0008/> says "Don't
> > >> > use spaces around the '=' sign when used to indicate a keyword
> > >> > argument or a default parameter value."
> > >> >
> > >> > I will keep this in mind. I have created another branch with partial
> > >> changes suggested above. Here, you can find the changes,
> > >>
> > >> http://bazaar.launchpad.net/~syst3mw0rm/mailman/808821/revision/7080
> > >>
> > >>
> > >>
> > >> --
> > >> Aamir Khan | 3rd Year | Computer Science & Engineering | IIT Roorkee
> > >>
> > >>
> > >> ------------------------------
> > >>
> > >> Message: 3
> > >> Date: Sat, 18 Feb 2012 10:45:28 -0800
> > >> From: Mark Sapiro <mark at msapiro.net>
> > >> To: Aamir Khan <syst3m.w0rm at gmail.com>
> > >> Cc: Mailman-Developers at python.org
> > >> Subject: Re: [Mailman-Developers] Probe messages should not sent
> > >> Precedenceheader
> > >> Message-ID: <PC195201202181045280109fb8c76c9 at MSAPIRO>
> > >> Content-Type: text/plain; charset=iso-8859-1
> > >>
> > >> Aamir Khan wrote:
> > >> >
> > >> >Mark Sapiro <mark at msapiro.net> wrote:
> > >> >
> > >> >>
> > >> >> Which means that bin/disabled.py won't work because it hasn't been
> > >> >> fully converted from 2.1 yet. It should be using the send_probe()
> > >> >> function instead of sendNextNotification().
> > >> >>
> > >> >
> > >> >Yes. I also think so. I have changed the function to send_probe()
> and ran
> > >> >through all the test again to make sure that nothing breaks.
> > >>
> > >>
> > >> I don't think you can simply change mlist.sendNextNotification(member)
> > >> to mlist.send_probe(member) because send_probe() is not a list method,
> > >> plus it requires a message argument in addition to the member
> argument.
> > >>
> > >> Also, it is apparent that the test suite is not testing
> bin/disabled.py
> > >> or it would have been failing all along.
> > >>
> > >> --
> > >> Mark Sapiro <mark at msapiro.net> The highway is for gamblers,
> > >> San Francisco Bay Area, California better use your sense - B. Dylan
> > >>
> > >>
> > >>
> > >> ------------------------------
> > >>
> > >> _______________________________________________
> > >> Mailman-Developers mailing list
> > >> Mailman-Developers at python.org
> > >> http://mail.python.org/mailman/listinfo/mailman-developers
> > >>
> > >>
> > >> End of Mailman-Developers Digest, Vol 274, Issue 10
> > >> ***************************************************
> > >>
> > >
> > >
> > _______________________________________________
> > Mailman-Developers mailing list
> > Mailman-Developers at python.org
> > http://mail.python.org/mailman/listinfo/mailman-developers
> > Mailman FAQ: http://wiki.list.org/x/AgA3
> > Searchable Archives:
> http://www.mail-archive.com/mailman-developers%40python.org/
> > Unsubscribe:
> http://mail.python.org/mailman/options/mailman-developers/f%40state-of-mind.de
> >
> > Security Policy: http://wiki.list.org/x/QIA9
>
>
>
>
>
>
>
> ------------------------------
>
> _______________________________________________
> Mailman-Developers mailing list
> Mailman-Developers at python.org
> http://mail.python.org/mailman/listinfo/mailman-developers
>
>
> End of Mailman-Developers Digest, Vol 274, Issue 12
> ***************************************************
>
More information about the Mailman-Developers
mailing list