[Mailman-Users] Small issue (hopefully) with upgrading/migrating from v2.1.9 to v2.1.18-1

[Chris Nulk]

On Wed, Jan 14, 2015 at 6:33 PM, Mark Sapiro <mark at msapiro.net> wrote:

> On 01/14/2015 04:11 PM, Chris Nulk wrote:
> >
> > I have run into a small problem.  One of the customizations I did was to
>
> ​.....​

>
> >
> > I think that addtional check is preventing my additional
> > attribute/property from accepting lists in the field.
>
>
> Correct.
>

​Thanks for input.  From the last time I did mods to the source​, you
helped me with a few changes.  Specifically, v2.1.9 didn't allow lists in
those fields.  You sent me a patch that backported that change from
v2.1.10.  When I did my checking, I saw that I no longer needed to do the
backport so the GUIBase.py file was dropped from needing the modification.
I am trying to make the minimal changes needed.  Looks like I will have to
add the file back.  Not a problem.


>
> > Before I go off and possibly muck my installation up, can I simply
> > duplicate the 'elif' section with the property.endswith code and replace
> > the '_these_nonmembers' with my attribute/property?
> >
> > Or is a better solution to do something list:
> >                          elif (wtype == mm_cfg.EmailListEx and
> > addr.startswith('@')
> >                             and (property.endswith('_these_nonmembers')
> > or (property.endswith('my_attribute'))):
> > Would that work?
> >
> > Or even more optimially, I am open to the correct solution to my issue.
>
>
> I would replace the elif clause with
>
>      elif (wtype == mm_cfg.EmailListEx and addr.startswith('@') and
>              (property.endswith('_these_nonmembers') or
>               property == 'my_attribute')
>
> indented to the proper level.
>

​Cool.  I will make the change like you recommend.


>
> DRY
>

​DRY?

Thanks Mark.  You are an awesome help.

Chris

P.S. Using GMail to reply just really ***** (better not say it).   Who
thought up this P**** o* P** interface?