[Matplotlib-devel] protected branches on GH

[Ryan May]

We use it here at work. Protected branches are just that--you CANNOT push a
commit (i.e. a hash) until it has passed the checks. One note, though, is
that the commit must have passed the checks running on top of *current*
master. That means if master changes (i.e. you merge another PR), you have
to update the PR (you can use the web button to merge master into the
branch, but ewww) and re-run the status checks before it can merge.

For us, it's still been better to enforce that tests stay green, but we
don't have the rate of PR's that matplotlib has.

Ryan

On Fri, Nov 6, 2015 at 10:07 PM, Nathaniel Smith <njs at pobox.com> wrote:

> On Fri, Nov 6, 2015 at 8:45 PM, Thomas Caswell <tcaswell at gmail.com> wrote:
> > Hey all,
> >
> > GH now lets you protect branches which prevents people from
> force-pushing or
> > deleting those branches;
> > https://github.com/matplotlib/matplotlib/settings/branches.
> >
> > I have protected our 'production' branches.
> >
> > There is also an option to require status checks to pass before merging
> to a
> > given branch, but that would break our current cherry-pick workflow and
> mean
> > that we could not use our judgement to over-rule travis.ci ;)
>
> It looks like you can set it so that the status checks are enforced on
> normal users, but administrators are allowed to ignore it:
>   https://help.github.com/articles/enabling-required-status-checks/
>
> What I really want to know is whether it prevents simply pushing
> directly to the branch. That would be really awesome because it would
> mean you could hand out commit bits like candy without worrying that
> unreviewed code could creep into the repo... but there's no indication
> of this anywhere. (OTOH if direct pushes *are* still allowed, then
> that also provides a method for circumventing the status checks when
> desired -- just do a manual merge and push from the command line.)
>
> -n
>
> --
> Nathaniel J. Smith -- http://vorpus.org
> _______________________________________________
> Matplotlib-devel mailing list
> Matplotlib-devel at python.org
> https://mail.python.org/mailman/listinfo/matplotlib-devel
>



-- 
Ryan May
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20151109/a94df35e/attachment.html>