[Moin-devel] Simple patch for attach file over SSL

Joo-won Jung sanori at sanori.net
Wed Sep 4 11:26:06 EDT 2002


On Wed, Sep 04, 2002 at 07:45:18PM +0200, Juergen Hermann wrote:
> On Wed, 4 Sep 2002 21:07:26 +0900, Joo-won Jung wrote:
> 
> >+            os.environ.get('HTTPS', '') != '' or \
> 
> I think "HTTPS" can hold the values "on" and "off", can you check (e.g. 
> using the "?test" url) that it is "on" when SSL is active so we can
> provide a tighter condition.

Yes, you are right.

'HTTPS=on' is given when it is connected over SSL.
(But HTTPS variable is not provided to CGI when normal HTTP connection.
 So, I ignored it.)

Therefore,

+		os.environ.get('HTTPS', '') == 'on' or \

may check tighter condition.

I changed the code as above, tested MoinMoin over both HTTPS and
HTTP and found that it works correctly on TWikiDraw pictures.

Hope this helps.

-Sanori





More information about the Moin-devel mailing list