[Moin-devel] [ moin-Bugs-974719 ] Edit window size not honored

[SourceForge.net]

Bugs item #974719, was opened at 2004-06-17 15:07
Message generated for change (Settings changed) made by thomaswaldmann
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108482&aid=974719&group_id=8482

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Neil Brooks (nfbrooks)
Assigned to: Nobody/Anonymous (nobody)
Summary: Edit window size not honored

Initial Comment:
Setting the edit window size in UserPreferences to a size 
other than the default is giving odd results.

Sometimes the window is displayed correctly until any 
editing is done when it reverts to the default width.

Sometimes the new setting is ignored.

I need to reduce the width of the window to 65 as the 
rightside bar themes (rightside and nirlo2) hide the edit 
text. (which may be another bug)

This happens on my wiki running 1.2.2 and 
http://moinmoin.wikiwikiweb.de/ The browser did not 
seem to be a factor (IE6 and Firefox 0.9)



----------------------------------------------------------------------

>Comment By: Thomas Waldmann (thomaswaldmann)
Date: 2004-07-21 17:58

Message:
Logged In: YES 
user_id=100649

removed the columns setting in favour of width=100%

will be in 1.2.3


----------------------------------------------------------------------

Comment By: Thomas Waldmann (thomaswaldmann)
Date: 2004-07-04 13:07

Message:
Logged In: YES 
user_id=100649

the question is if we rather should remove the cols setting
from userpref (does it make any sense?) or if we remove the
width=100% (who would want to use less?).

rightside and nirlo2 seem to be fixed on
moinmoin.wikiwikiweb.de, please check it there.

----------------------------------------------------------------------

Comment By: Neil Brooks (nfbrooks)
Date: 2004-07-01 15:34

Message:
Logged In: YES 
user_id=1065345

The problem has been traced to PageEditor.py line 316.
This is:
self.request.write('<textarea name="savetext" rows="%d" 
cols="%d" style="width:100%%">%s</textarea>'

The 'style=' is overriding the 'cols='. This implies that the cols 
setting doesn't work for left sided themes either. 
When  'style="width:100%%' is removed, the textarea shrinks 
to what you'd expect when you supply a 'cols=65'. It even 
shrinks with the default value of 80. This means that when 
this is fix is applied the usual editor window will shrink.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108482&aid=974719&group_id=8482