[Moin-devel] Re: Re: Re: Is it true file upload functionality will be removed from 1.4?

[Alexander Schremmer]

On Sat, 9 Apr 2005 23:37:07 -0400, Martin Gignac wrote:

> I've did some more tests with large files, MoinMoin and Twisted 1.3.0, and found
> that the larger the file is, the longer the CPU "hogging" lasts. It eventually
> dies down and the file ends up being downloaded, but in the case of very large
> files (> 100MB), I wasn't patient enough to wait for it... ;)

the problem could be reproduced on Linux. So it seems to be a bug in the
code.

> So my problems *does* seem to be limited to when I use MoinMoin with Twisted.

Standalone should be faster anyway.

> I had another question while we are on the subject of CGI GETs. If I use direct
> file serving, I can use the mechanism of the 'HTTP 304 Not Modified' response
> returned by the web server (Apache, Twisted Web, etc.) so that I avoid
> downloading images in a wiki page which I already have in my browser cache.

if your browser if RFC compliant, it will request the image everytime again
(independent from the current method of MoinMoin invocation -
CGI/Twisted/etc.). We could send some cache-control headers to mitigate
this issue. Sending 304 would need request parsing logic in the code.
Enhancing the code by that amount is not planned because 1.4 will handle
downloads differently in any case.

Kind regards,
Alexander

PS.: Just for the record, Martin is using Twisted 1.3 on Python 2.4.1 on
Windows 2000