[Neuroimaging] Upcoming nipy release

Matthew Brett matthew.brett at gmail.com
Fri Sep 25 02:08:39 CEST 2015


On Sat, Aug 29, 2015 at 1:59 AM, Matthew Brett <matthew.brett at gmail.com> wrote:
> Hi,
> On Fri, Aug 28, 2015 at 2:59 PM, Yaroslav Halchenko
> <lists at onerussian.com> wrote:
>> On Fri, 28 Aug 2015, Matthew Brett wrote:
>>> I'm just finishing up some fixes to get the tests passing for nipy.
>>> If any of you have a few minutes, I would be very grateful for reviews
>>> on the current PRs:
>>> https://github.com/nipy/nipy/pull/348
>>> https://github.com/nipy/nipy/pull/346
>>> https://github.com/nipy/nipy/pull/341
>>> One we have all the tests passing on travis, then we are in the hope
>>> straight for a release.
>> FWIW, I don't remember if I have shared before...
>> For DataLad I have setup buildbot to
>> 1. forward build reports back to travis
>> 2. monitor for PRs and run tests on them as well
>> it might be a well worth addition to nibotmi, although I don't know when
>> myself I could jump to implement that, so decided just to share for now.
>> Demo -- any datalad PR on github (with less than a 100 or so commits, some bug
>> causes my ad-hoc setup to not pick up those PRs for testing), e.g.:
>> https://github.com/datalad/datalad/pull/101 (scroll to the bottom ;) some are
>> failing atm)
>> Our setup is https://github.com/datalad/buildbot which is in large based on
>> https://github.com/ethereum/ethereum-buildbot and apparently work on supporting
>> pull_requests in stock buildbot since then was accepted!
>> https://github.com/buildbot/buildbot/pull/1632
>> so I might look into redoing it using stock features
> That would be really good - if you do have time to do it.  It would be
> ideal to get the buildbots integrated into the github interface...

After thinking about it for a little bit, I was worried about a)
overwhelming the buildbot machines, and b) allowing any PR to execute
code on the buildbot machines.  I wonder whether we could use Homu


I think this would mean that approved reviewers could mark the PR with
a comment like '@homu-user r+' to the PR, and this could trigger
builds both on travis-ci, and the buildbots, and the PR would only get
merged if the all the tests pass.  I think.

That seems like a good mix - an approved reviewer has to OK it before
it is tested on the buildbots and travis before merging.

What do you think?



More information about the Neuroimaging mailing list