[Neuroimaging] Integrating code formatting in NiBabel

[Zvi Baratz]

Hi,

I do generally prefer double-quotes, but I am happy to conform with
whatever. The main thing for me as having something consistent that can be
applied automatically. Let's continue on GitHub.

Thank you,
Zvi

On Thu, Dec 29, 2022 at 1:15 AM Matthew Brett <matthew.brett at lis.ac.uk>
wrote:

> Hi,
>
> On Wed, Dec 28, 2022 at 9:11 PM Christopher Markiewicz
> <markiewicz at stanford.edu> wrote:
> >
> > Hi Zvi,
> >
> > I agree we should switch to auto-formatting. I started on a PR a while
> back to switch to using blue and isort:
> https://github.com/nipy/nibabel/pull/1124
> >
> > There are a couple issues I have with black that I hoped to resolve with
> blue, but the larger one is in limbo (which is why 1124 stalled):
> https://github.com/grantjenks/blue/pull/83
> >
> > The lesser one is that I prefer single quotes. If others feel strongly
> about black, I'm okay losing that argument here as in so many other places.
> The main thing that I would insist on is that chunks of code that are more
> understandable in a tabular format than a tree format need to be protected
> from the formatter.
> >
> > Happy to continue the discussion here or on GitHub.
>
> Only to note that Astropy recently committed itself to using Black,
> after a fairly long discussion and an Astropy Proposal for
> Enhancement:
>
> https://github.com/astropy/astropy-APEs/blob/main/APE20.rst
>
>
> https://docs.astropy.org/en/latest/development/codeguide.html#coding-style-conventions
>
> I also find I prefer single-quoted strings, for some reason, but -
> probably like Chris - I don't feel strongly about it.
>
> Cheers,
>
> Matthew
> _______________________________________________
> Neuroimaging mailing list
> Neuroimaging at python.org
> https://mail.python.org/mailman/listinfo/neuroimaging
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.python.org/pipermail/neuroimaging/attachments/20221229/db81d806/attachment.html>