[New-bugs-announce] [issue6065] bdist_msi.py failed assert when including extension modules

[Tim Golden]

New submission from Tim Golden <mail at timgolden.me.uk>:

Attempting to build an MSI installer using bdist_msi fails
under Windows when the module contains extension modules.
The assert at line 197 fires as no target version has been
specified. The attached tentative patch makes sure a target
version is set to the current version which has the added
advantage that the installer does not offer all possible
versions which would be inappropriate for a binary extension.

Patch against r72306

----------
files: bdist_msi.patch
keywords: patch
messages: 88098
nosy: tim.golden
severity: normal
status: open
title: bdist_msi.py failed assert when including extension modules
Added file: http://bugs.python.org/file14019/bdist_msi.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue6065>
_______________________________________
-------------- next part --------------
Index: bdist_msi.py
===================================================================
--- bdist_msi.py	(revision 72507)
+++ bdist_msi.py	(working copy)
@@ -141,6 +141,8 @@
             bdist_base = self.get_finalized_command('bdist').bdist_base
             self.bdist_dir = os.path.join(bdist_base, 'msi')
         short_version = get_python_version()
+        if (not self.target_version) and self.distribution.has_ext_modules():
+          self.target_version = short_version
         if self.target_version:
             self.versions = [self.target_version]
             if not self.skip_build and self.distribution.has_ext_modules()\