[New-bugs-announce] [issue8989] email.utils.make_msgid: specify domain

[Adrian von Bidder]

New submission from Adrian von Bidder <avbidder at fortytwo.ch>:

Using the hostname for the domain part of a Message-Id is probably the right thing usually but users may want to override this.

Please consider this rather trivial patch:

=====
--- utils.py.orig       2010-06-13 16:59:30.533861099 +0200
+++ utils.py    2010-06-13 17:02:18.650697979 +0200
@@ -173,13 +173,15 @@
 
 
 

-def make_msgid(idstring=None):
+def make_msgid(idstring=None, domain=None):
     """Returns a string suitable for RFC 2822 compliant Message-ID, e.g:
 
     <20020201195627.33539.96671 at nightshade.la.mastaler.com>
 
     Optional idstring if given is a string used to strengthen the
-    uniqueness of the message id.
+    uniqueness of the message id.  The domain part of the Message-ID
+    defaults to the locally defined hostname, but can be specified
+    explicitly.
     """
     timeval = time.time()
     utcdate = time.strftime('%Y%m%d%H%M%S', time.gmtime(timeval))
@@ -189,8 +191,9 @@
         idstring = ''
     else:
         idstring = '.' + idstring
-    idhost = socket.getfqdn()
-    msgid = '<%s.%s.%s%s@%s>' % (utcdate, pid, randint, idstring, idhost)
+    if domain is None:
+        domain = socket.getfqdn()
+    msgid = '<%s.%s.%s%s@%s>' % (utcdate, pid, randint, idstring, domain)
     return msgid
 
 
=====

thanks & greetings
-- vbi

----------
components: Library (Lib)
messages: 107734
nosy: avbidder at fortytwo.ch
priority: normal
severity: normal
status: open
title: email.utils.make_msgid: specify domain
versions: Python 2.6, Python 3.1

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue8989>
_______________________________________