[New-bugs-announce] [issue10361] Fix issue 9995 - distutils forces developers to store password in cleartext (issue2874041)

[Éric Araujo]

New submission from Éric Araujo <merwok at netwok.org>:

Looks globally good to me.

http://codereview.appspot.com/2874041/diff/2001/cmd.py
File cmd.py (right):

http://codereview.appspot.com/2874041/diff/2001/cmd.py#newcode55
cmd.py:55: :param distutils.dist.Distribution dist: distribution to work
with
Please don’t include unrelated changes in your patch.

Also, Python does not use :param: in docstrings.

http://codereview.appspot.com/2874041/diff/2001/command/upload.py
File command/upload.py (right):

http://codereview.appspot.com/2874041/diff/2001/command/upload.py#newcode53
command/upload.py:53: if not self.username and
self.distribution.username:
I’d prefer a clearer comparison, please use “is [not] None” and parens.

http://codereview.appspot.com/2874041/

----------
messages: 120776
nosy: eric.araujo, techtonik
priority: normal
severity: normal
status: open
title: Fix issue 9995 - distutils forces developers to store password in cleartext (issue2874041)

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue10361>
_______________________________________