[New-bugs-announce] [issue17612] hooks/mail.py requires [smtp] host to be set, despite a comment to the contrary

[Eric V. Smith]

New submission from Eric V. Smith:

In the mail hook, there's a comment that says:

'''
To set the SMTP server to something other than localhost, add a [smtp]
section to your hgrc:

[smtp]
host = mail.python.org
port = 25
'''

This is not true. The default host is '', which tells smtplib.SMTP to not make an initial connection. If we want the comment to be correct, then we need to set 'localhost' as the default:

-    host = ui.config('smtp', 'host', '')
+    host = ui.config('smtp', 'host', 'localhost')

I guess there's some chance that we want to force the smtp host to be set. If that's the case then then comment should be changed and the code modified to require the host be specified in the config file (or at least a better error message than 'please run connect() first').

Adding Antoine because annotate points to him for these lines.

----------
assignee: eric.smith
keywords: easy
messages: 185777
nosy: eric.smith, pitrou
priority: normal
severity: normal
status: open
title: hooks/mail.py requires [smtp] host to be set, despite a comment to the contrary

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue17612>
_______________________________________