[New-bugs-announce] [issue24012] Add error checks to PyInit_pyexpat()

[Christian Heimes]

New submission from Christian Heimes:

Similar to #24011 and #24010 the pyexpat module's init function fails to check some return values for NULL. The patch doesn't include proper reference cleanups as most of the other parts of PyInit_pyexpat() don't cleanup on error, too.

CID 982779 (#2 of 2): Dereference null return value (NULL_RETURNS)
dereference: Dereferencing a pointer that might be null sys_modules when calling PyDict_SetItem

CID 982240 (#2 of 2): Unchecked return value (CHECKED_RETURN)
check_return: Calling PyDict_SetItem without checking return value (as is done elsewhere 158 out of 174 times)

----------
components: Extension Modules
files: pyexpat.patch
keywords: patch
messages: 241555
nosy: christian.heimes, eli.bendersky, scoder
priority: normal
severity: normal
stage: patch review
status: open
title: Add error checks to PyInit_pyexpat()
type: behavior
versions: Python 3.4, Python 3.5
Added file: http://bugs.python.org/file39129/pyexpat.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue24012>
_______________________________________