[New-bugs-announce] [issue23300] An improper change in httplib.py

Guohua Ouyang report at bugs.python.org
Thu Jan 22 12:50:08 CET 2015

New submission from Guohua Ouyang:

Following the issue 7776, there is a patch for 2.7 version.

Which changes the method of class HTTPConnection from "_set_hostport" to "_get_hostport"[1], it seems introduce in some incompatibility issues.

On my system, the file "/usr/lib64/python2.7/site-packages/mercurial/url.py" from package mercurial-3.0-2.fc21 still use the old method "_set_hostport". I met an error "AttributeError: httpsconnection instance has no attribute '_set_hostport'" when use this package. I only see this incompatibility issue so far.

And in the file httplib.py itself, [2] still use "self._conn._set_hostport(host, port)", which should be "self._conn._get_hostport(host, port)" if it's settled to rename "_set_hostport" to "_get_hostport".

[1] https://github.com/python/cpython/blob/2.7/Lib/httplib.py#L743
[2] https://github.com/python/cpython/blob/2.7/Lib/httplib.py#L1132

components: Library (Lib)
messages: 234488
nosy: guohua
priority: normal
severity: normal
status: open
title: An improper change in httplib.py
type: enhancement
versions: Python 2.7

Python tracker <report at bugs.python.org>

More information about the New-bugs-announce mailing list