[New-bugs-announce] [issue24130] Remove -fno-common compile option from OS X framework builds?

[Ned Deily]

New submission from Ned Deily:

As noted in msg242635 of issue23911, for some reason configure.ac adds the gcc -fno-common option for OS X framework builds.  Is this still necessary?  I'm guessing it might be vestigial code left over from the Mac toolbox support in Python 2 that was removed in Python 3.

diff configure.ac
--- a/configure.ac      Tue May 05 12:04:35 2015 -0700
+++ b/configure.ac      Tue May 05 16:47:34 2015 -0700
@@ -2101,9 +2101,6 @@
 AC_MSG_CHECKING(for --enable-framework)
 if test "$enable_framework"
 then
-       BASECFLAGS="$BASECFLAGS -fno-common -dynamic"
-       # -F. is needed to allow linking to the framework while
-       # in the build location.
        AC_DEFINE(WITH_NEXT_FRAMEWORK, 1,
          [Define if you want to produce an OpenStep/Rhapsody framework
          (shared library plus accessory files).])

Also, there seems to be a unused reference to $extra_undefs left over in configure.ac from the removed Mac toolbox support:

--- a/configure.ac      Tue May 05 12:04:35 2015 -0700
+++ b/configure.ac      Tue May 05 18:20:21 2015 -0700
@@ -2346,8 +2346,6 @@
        Linux*|GNU*) LINKFORSHARED="-Xlinker -export-dynamic";;
        # -u libsys_s pulls in all symbols in libsys
        Darwin/*)
-               LINKFORSHARED="$extra_undefs -framework CoreFoundation"
-
                # Issue #18075: the default maximum stack size (8MBytes) is too
                # small for the default recursion limit. Increase the stack size
                # to ensure that tests don't crash

----------
assignee: ned.deily
components: Build, Macintosh
messages: 242636
nosy: ned.deily, ronaldoussoren
priority: normal
severity: normal
stage: patch review
status: open
title: Remove -fno-common compile option from OS X framework builds?
versions: Python 3.5

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue24130>
_______________________________________