[New-bugs-announce] [issue24326] Audioop: weightB not divided by GCD, weightA divided twice

[David Moore]

New submission from David Moore:

Hi - 

During a code review of Modules/audioop.c I noted that weightB is never divided by the GCD while weightA is divided twice. This is contrary to the comment and appears to be a bug:

    /* divide weightA and weightB by their greatest common divisor */
    d = gcd(weightA, weightB);
    weightA /= d;
    weightA /= d;

The patch file below (hg diff) fixes this issue.

----------
components: Extension Modules
files: audioop.patch
keywords: patch
messages: 244392
nosy: David Moore
priority: normal
severity: normal
status: open
title: Audioop: weightB not divided by GCD, weightA divided twice
type: behavior
versions: Python 3.6
Added file: http://bugs.python.org/file39549/audioop.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue24326>
_______________________________________