[New-bugs-announce] [issue25334] telnetlib: process_rawq() and binary data

[Michael Walle]

New submission from Michael Walle:

The process_rawq() discards '\x00' and '\x11' bytes.

At least the '\x00' byte is specified by the standard as a No-Op. So this is standard conform according to RFC 854. But there is also the binary transmission mode for telnet (RFC 856). If I want to support this mode I have to receive these all bytes (just IACs are handled special) and I don't see a possibility to achieve this other that overwriting the process_rawq() method, which essentially means copying it and remove/replace the "if c == theNULL" etc checks. IMHO this is bad, because i copy a 64 lines method, just to modify two lines :(

I'd propose to move these checks to a new method, which then can be overwritten. See attached file for example.

----------
components: Library (Lib)
files: telnetlib.diff
keywords: patch
messages: 252472
nosy: mwalle
priority: normal
severity: normal
status: open
title: telnetlib: process_rawq() and binary data
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file40710/telnetlib.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue25334>
_______________________________________