[New-bugs-announce] [issue31275] Check fall-through in _codecs_iso2022.c

[Stefan Krah]

New submission from Stefan Krah:

The last fall-through warning is in _codecs_iso2022.c. IMO the
current code is equivalent to this, but I'm no codecs expert at
all:


diff --git a/Modules/cjkcodecs/_codecs_iso2022.c b/Modules/cjkcodecs/_codecs_iso2022.c
index 1ce4218f30..abf214880f 100644
--- a/Modules/cjkcodecs/_codecs_iso2022.c
+++ b/Modules/cjkcodecs/_codecs_iso2022.c
@@ -807,15 +807,9 @@ jisx0213_encoder(const Py_UCS4 *data, Py_ssize_t *length, void *config)
     case 2: /* second character of unicode pair */
         coded = find_pairencmap((ucs2_t)data[0], (ucs2_t)data[1],
                                 jisx0213_pair_encmap, JISX0213_ENCPAIRS);
-        if (coded == DBCINV) {
-            *length = 1;
-            coded = find_pairencmap((ucs2_t)data[0], 0,
-                      jisx0213_pair_encmap, JISX0213_ENCPAIRS);
-            if (coded == DBCINV)
-                return MAP_UNMAPPABLE;
-        }
-        else
+        if (coded != DBCINV) {
             return coded;
+        /* fall through */
 
     case -1: /* flush unterminated */
         *length = 1;

----------
messages: 300834
nosy: haypo, serhiy.storchaka, skrah
priority: normal
severity: normal
status: open
title: Check fall-through in _codecs_iso2022.c

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue31275>
_______________________________________