[New-bugs-announce] [issue29798] Handle "git worktree" in "make patchcheck"

Nick Coghlan report at bugs.python.org
Sun Mar 12 01:13:31 EST 2017


New submission from Nick Coghlan:

While backporting issue 29656 to get "make patchcheck" to play nice with git PR branches, I discovered an incompatibility between the way "git worktree" works and the assumptions in "patchcheck.py".

Specifically, in a worktree, ".git" is a file, rather than a directory:

    $ cat .git
    gitdir: /home/ncoghlan/devel/cpython/.git/worktrees/py27

So the current isdir() check should be relaxed to just an exists() check.

----------
assignee: ncoghlan
components: Demos and Tools
messages: 289481
nosy: ncoghlan
priority: normal
severity: normal
status: open
title: Handle "git worktree" in "make patchcheck"
type: behavior
versions: Python 2.7, Python 3.5, Python 3.6, Python 3.7

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue29798>
_______________________________________


More information about the New-bugs-announce mailing list