[New-bugs-announce] [issue35550] Some define guards for Solaris are wrong

[Jakub Kulik]

New submission from Jakub Kulik <kulikjak at gmail.com>:

Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Our recent Solaris python build ended up skipping these sections resulting in some obvious problems.

Defines should check for __sun instead.

(link: http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solaris)

----------
components: Build
messages: 332284
nosy: kulikjak
priority: normal
severity: normal
status: open
title: Some define guards for Solaris are wrong
versions: Python 3.7

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue35550>
_______________________________________