[New-bugs-announce] [issue32528] Change base class for futures.CancelledError

Марк Коренберг report at bugs.python.org
Wed Jan 10 11:31:15 EST 2018

New submission from Марк Коренберг <socketpair at gmail.com>:

I have discoverd one very ugly pattern connected with asyncio. Many times I see code like this:

    await something()
except Exception:
    log.error('Opertaion failed -- will retry later.')

Seems, everything is fine, but asyncio.CancelledError unintentionally
also suppressed in that code. So, sometimes coroutines are not cancellable.

In order to mitigate thi, we had to write:

    await something()
except CancelledError:
except Exception:
    log.error('Opertaion failed. will retry later.')

So, what I propose: Basically is to change base class for asyncio.CancelledError
from Exception (yes, I know concurrent.futures and it's `Error` class) to BaseException.

Just like `SystemExit` and other SPECIAL exceptions.

Yes, I know that it would be incompatible change. But I suspect that impact will be minimal. Documentation for concurrent.futures and asyncio does not say that this exception is derived from Exception.

components: asyncio
messages: 309772
nosy: asvetlov, socketpair, yselivanov
priority: normal
severity: normal
status: open
title: Change base class for futures.CancelledError
versions: Python 3.7, Python 3.8

Python tracker <report at bugs.python.org>

More information about the New-bugs-announce mailing list