[New-bugs-announce] [issue35881] test_type_comments leaks references and memory blocks

Pablo Galindo Salgado report at bugs.python.org
Fri Feb 1 09:02:45 EST 2019


New submission from Pablo Galindo Salgado <pablogsal at gmail.com>:

The refleak buildbots have detected that test_type_comments is leaking references. Example failure:

https://buildbot.python.org/all/#/builders/1/builds/490/steps/4/logs/stdio

test_type_comments leaked [37, 37, 37] references, sum=111
test_type_comments leaked [11, 12, 11] memory blocks, sum=34
1 test failed again:
    test_type_comments

Bisecting shows that PR11645 is the one that introduced the refleaks:

https://github.com/python/cpython/pull/11645/files#

After some hours of debugging, I have identified the (possible) cause of the majority of the refleaks. 

The type_comments created in ast.c with new_type_comment() never reaches 0 reference counts. This **seems** to be because the cleanup for the stmt_ty elements where the type_comments are included never call DECREF on these elements when destroyed unless I am missing something fundamental.

----------
components: Interpreter Core, Tests
messages: 334676
nosy: gvanrossum, lukasz.langa, pablogsal
priority: normal
severity: normal
status: open
title: test_type_comments leaks references and memory blocks
versions: Python 3.8

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue35881>
_______________________________________


More information about the New-bugs-announce mailing list