[New-bugs-announce] [issue44074] patchcheck checks against branch "master" not "main"
report at bugs.python.org
Sat May 8 04:05:12 EDT 2021
New submission from Rory Yorke <rory.yorke at gmail.com>:
I'm probably missing something, but "master" seems hard-coded into patchcheck.py, and I couldn't find any related issues on bpo.
Checked on branch off 42fcad2.
When I ran patchcheck:
rory at rory-latitude:~/src/cpython$ ./python Tools/scripts/patchcheck.py
Getting base branch for PR ... origin/master
Getting the list of files that have been added/changed ... fatal: ambiguous argument 'origin/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
The obvious offender is line 81 of Tools/scripts/patchcheck.py:
base_branch = "master"
Changing this to "main" results in useful output, but I imagine one
would want to check for both "master" and "main" for a while yet?
components: Demos and Tools
title: patchcheck checks against branch "master" not "main"
Python tracker <report at bugs.python.org>
More information about the New-bugs-announce