[Numpy-discussion] Review of issue 825

[Charles R Harris]

On Wed, Jun 25, 2008 at 8:42 PM, Charles R Harris <charlesr.harris at gmail.com>
wrote:

> Hi Neil,
>
> On Wed, Jun 25, 2008 at 2:26 PM, Neil Muller <drnlmuller+scipy at gmail.com<drnlmuller%2Bscipy at gmail.com>>
> wrote:
>
>> On Wed, Jun 25, 2008 at 8:46 PM, Charles R Harris
>> <charlesr.harris at gmail.com> wrote:
>> >
>> >
>> > Looks to me like the NPY_ALIGNED flag is incorrectly set. Can you check
>> > this  by printing the results of
>> >
>> > PyArray_CHKFLAGS(ap, NPY_ALIGNED)
>>
>> For the test listed in the ticket, the array isn't flagged as aligned
>> - ap->flags =  NPY_CONTIGUOUS | NPY_FORTRAN | NPY_WRITEABLE
>>
>> I'm under the impression that NPY_ALIGNED refers to the alignment of
>> the entire entry, though, in which case it's irrelevant here, since
>> the problem is with the internal alignment of items within a single
>> array entry.
>>
>
> It looks like it refers to the item. Look  at VOID_getitem to see how it is
> set item by item.
>
> Can you try the attached patch?
>

Oops, try this one instead. I'm not sure why the last one worked.

Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20080625/535285b0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sparc.patch
Type: text/x-patch
Size: 2613 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20080625/535285b0/attachment.bin>