[Numpy-discussion] Remove deprecated skiprows

Wes McKinney wesmckinn at gmail.com
Tue Apr 5 19:20:11 EDT 2011


On Tue, Apr 5, 2011 at 5:52 PM, Ralf Gommers
<ralf.gommers at googlemail.com> wrote:
> On Tue, Apr 5, 2011 at 11:45 PM, Skipper Seabold <jsseabold at gmail.com> wrote:
>> On Sun, Apr 3, 2011 at 8:20 PM, Charles R Harris
>> <charlesr.harris at gmail.com> wrote:
>>> Should skiprows be removed?
>>>
>>>     if skiprows:
>>>         warnings.warn(\
>>>             "The use of `skiprows` is deprecated, it will be removed in
>>> numpy 2.0.\n" \
>>>             "Please use `skip_header` instead.",
>>>             DeprecationWarning)
>>>         skip_header = skiprows
>>>
>>> Its been deprecated since 1.4. Personally, I like skiprows better than
>>> skip_header ;)
>>>
>>
>> +1 for skiprows. I always have to look it up.
>
> To me one is not much better than the other, but -1 for skiprows
> because un-deprecating it and deprecating skip_header is inconsistent
> and annoying for users.
>
> Ralf
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion at scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion
>

FYI:

http://docs.python.org/library/warnings.html

"DeprecationWarning	Base category for warnings about deprecated
features (ignored by default)."

Maybe DeprecationWarnings should be changed to something that isn't
ignored by default so users see it?



More information about the NumPy-Discussion mailing list