[Numpy-discussion] Rationale for simple_capsule_dtor to be static but non-inline ?
Charles R Harris
charlesr.harris at gmail.com
Thu Feb 10 06:26:40 EST 2011
On Wed, Feb 9, 2011 at 10:50 PM, David <david at silveregg.co.jp> wrote:
> in npy3_compat.h, one function simple_capsule_dtor is defined as static
> but non-inline. AFAIK, there is no reason not to put inline (if
> supported by the compiler of course) for a static function defined in a
> header. Unless I hear someone justify it, I will change it,
It's only used as an argument so it needs to be defined, there is no place
that it can be inlined. The NpyCapsule stuff could probably be moved out of
the header into a compatibility library somewhere but that would require the
builds of numpy/scipy to all link with that library.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the NumPy-Discussion