[Numpy-discussion] NEP for faster ufuncs

David Cournapeau cournape at gmail.com
Tue Jan 4 07:34:19 EST 2011

On Wed, Dec 22, 2010 at 11:20 AM, Mark Wiebe <mwwiebe at gmail.com> wrote:
> On Tue, Dec 21, 2010 at 6:06 PM, David <david at silveregg.co.jp> wrote:
>> <snip>
>> This looks pretty cool. I hope to be able to take a look at it during
>> the christmas holidays.
> Thanks!

Ok, I took some time to look into it, but I am far from understanding
everything yet. I will need more time.

One design issue which bothers me a bit is the dynamically created
structure for the iterator - do you have some benchmarks which show
that this design is significantly better than a plain old C data
structure with a couple of dynamically allocated arrays ? Besides
bypassing the compiler type checks, I am a bit worried about the
ability to extend the iterator through "inheritence in C" like I did
with neighborhood iterator, but maybe I should just try it.

I think the code would benefit from smaller functions, too - 500+
lines functions is just too much IMO, it should be split up.

To get a deeper understanding of the code, I am starting to implement
several benchmarks to compare old and new iterator - do you already
have some of them handy ?

Thanks for the hard work, that's a really nice piece of code,


More information about the NumPy-Discussion mailing list