[Numpy-discussion] code review request: masked dtype transfers

[Mark Wiebe]

On Sat, Jul 9, 2011 at 2:38 PM, Nathaniel Smith <njs at pobox.com> wrote:

> On Sat, Jul 9, 2011 at 11:29 AM, Mark Wiebe <mwwiebe at gmail.com> wrote:
> > typedef npy_uint8 npy_mask;
> > #define NPY_MASK NPY_UINT8
> > #define NPY_MASK_ISEXPOSED(mask) (((mask)&0x01) != 0)
> > #define NPY_MASK_GETPAYLOAD(mask) (((npy_mask)mask) >> 1)
> > #define NPY_MASK_MAKEMASK(exposed, payload) ((npy_mask)(exposed&0x01) |
> > (npy_mask)(payload << 1))
>
> Even better, these should be inline functions instead of macros... (or
> is there some horrible old compiler that we care about that that
> wouldn't work for?)
>

That's a good idea, it's always worthwhile to use the little bit of type
checking the C compiler will let you. NumPy has a macro NPY_INLINE which is
used to define inline functions.

-Mark


>
> -- Nathaniel
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion at scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20110709/07268a87/attachment.html>