[Numpy-discussion] loadtxt/savetxt tickets

Paul Anton Letnes paul.anton.letnes at gmail.com
Sat Mar 26 08:11:46 EDT 2011


I have had a look at the list of numpy.loadtxt tickets. I have never contributed to numpy before, so I may be doing stupid things - don't be afraid to let me know!

My opinions are my own, and in detail, they are:
    I attach a possible patch. FWIW, I agree with the request. The patch is written to be compatible with the fix in ticket #1562, but I did not test that yet.
    This seems like a rather trivial feature enhancement. I attach a possible patch.
    The suggested patch seems reasonable to me, but I do not have a full list of what objects loadtxt supports today as opposed to what this patch will support.
    I attach a possible patch. This could also be the default behavior to my mind, since the function caller can simply call numpy.squeeze if needed. Changing default behavior would probably break old code, however.
    The fix suggested in the ticket seems reasonable, but I have never used record arrays, so I am not sure  of this.
    Adding this functionality could break old code, as some old datafiles may have empty lines which are now simply ignored. I do not think the feature is a good idea. It could rather be implemented as a separate function.
    I do not see the need for this enhancement. In my eyes, the usecols kwarg does this and more. Perhaps I am misunderstanding something here.
	It is not clear to me whether loadtxt is supposed to support missing values in the fashion indicated in the ticket.
    These tickets seem to have the same origin of the problem. I attach one possible patch. The previously suggested patches that I've seen will not correctly convert floats to ints, which I believe my patch will.

I hope you find this useful! Is there some way of submitting the patches for review in a more convenient fashion than e-mail?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1562.patch
Type: application/octet-stream
Size: 1515 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20110326/1fabeabe/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1163.patch
Type: application/octet-stream
Size: 1015 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20110326/1fabeabe/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1731.patch
Type: application/octet-stream
Size: 1399 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20110326/1fabeabe/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1752.patch
Type: application/octet-stream
Size: 631 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20110326/1fabeabe/attachment-0003.obj>
-------------- next part --------------

On 25. mars 2011, at 16.06, Charles R Harris wrote:

> Hi All,
> Could someone with an interest in loadtxt/savetxt look through the associated tickets? A search on the tickets using either of those keys will return fairly lengthy lists.
> Chuck
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion at scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion

More information about the NumPy-Discussion mailing list