[Numpy-discussion] Separating out the maskna code
njs at pobox.com
Sun May 20 14:06:37 EDT 2012
On Sun, May 20, 2012 at 6:59 PM, Nathaniel Smith <njs at pobox.com> wrote:
>> I have not reviewed it in detail, but in general I would be very supportive of your plan to commit this to master, make a 1.7 release (without the ReduceWrapper) function and then work on the masked array / ndarray separation plan for 1.8
>> Of course, first I would want to hear from Mark, to hear his comments about what was removed.
> Definitely. I'm pretty sure I didn't accidentally sweep up anything
> else in my net besides what it says in the commit messages (simply
> because it's hard to do that when all you're doing is grepping for
> HASMASKNA and friends), but he knows this code better than I do.
Also on that note, if someone can merge the PyArray_Diagonal PR then I
can sort out the conflicts and then make a PR for this, to make review
More information about the NumPy-Discussion