[Numpy-discussion] Requesting Code Review of nanmedian ENH

[Eelco Hoogendoorn]

hi david,

I havnt run the code; but the _replace_nan(0) call worries me; especially
considering that the unit tests seem to deal with positive numbers
exclusively. Have you tested with mixed positive/negative inputs?



On Sun, Feb 16, 2014 at 6:13 PM, David Freese <dfreese at stanford.edu> wrote:

> Hi everyone,
>
> I put together a np.nanmedian function to extend np.median to handle nans.
>  Could someone review this code and give me some feedback on it before I
> submit a pull request for it?
>
> https://github.com/dfreese/numpy/compare/master...feature;nanmedian
>
> Thanks,
> David
>
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion at scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20140216/a870fef6/attachment.html>