[Numpy-discussion] PR #7083: ENH: Added 'doane' and 'sqrt' estimators to np.histogram

Joseph Fox-Rabinovitz jfoxrabinovitz at gmail.com
Thu Jan 21 13:35:03 EST 2016


I fixed the issue by checking if x.size > 2 before the calculation. An
error should never need to be raised at that point. The build passes
now and the results appear to be correct.

On Thu, Jan 21, 2016 at 2:17 AM, Jaime Fernández del Río
<jaime.frio at gmail.com> wrote:
> The tests are not passing, seems like you are taking the sqrt of a negative
> number, may want to check the inputs and raise a more informative error (and
> add a test for it).
>
> Jaime
>
> On Thu, Jan 21, 2016 at 7:51 AM, Joseph Fox-Rabinovitz
> <jfoxrabinovitz at gmail.com> wrote:
>>
>> Please let me know if there is anything wrong or missing. I have added
>> a couple of estimators that I find useful sometimes.
>>
>>     -Joe
>> _______________________________________________
>> NumPy-Discussion mailing list
>> NumPy-Discussion at scipy.org
>> https://mail.scipy.org/mailman/listinfo/numpy-discussion
>
>
>
>
> --
> (\__/)
> ( O.o)
> ( > <) Este es Conejo. Copia a Conejo en tu firma y ayúdale en sus planes de
> dominación mundial.
>
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion at scipy.org
> https://mail.scipy.org/mailman/listinfo/numpy-discussion
>



More information about the NumPy-Discussion mailing list