[Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

Stephan Hoyer shoyer at gmail.com
Tue Oct 18 19:44:03 EDT 2016


On Tue, Oct 18, 2016 at 4:18 PM, Allan Haldane <allanhaldane at gmail.com>
wrote:

> As for whether it should default to "True" or "False", the arguments I
> see are:
>
>  * False, because that is the way most functions like `np.ma.sum`
>    already work, as well as matlab and octave's similar "nanconv".
>
>  * True, because its effects are more visible and might lead to less
>    surprises. The "False" case seems like it is often not what the user
>    intended. Eg, it affects the overall normalization of normalized
>    kernels, and the choice of 0 seems arbitrary.
>
> If no one says anything, I'd probably go with True
>

I also have serious concerns about if it ever actually makes sense to use
`propagate_mask=False`.

So, I think it's definitely appropriate to default to `propagate_mask=True`.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20161018/ca491ef9/attachment.html>


More information about the NumPy-Discussion mailing list