[Numpy-discussion] PR Cleanup

Ralf Gommers ralf.gommers at gmail.com
Tue Sep 25 15:12:43 EDT 2018


On Tue, Sep 25, 2018 at 5:35 PM Marten van Kerkwijk <
m.h.vankerkwijk at gmail.com> wrote:

> Hi Chuck,
>
> Over at astropy we have a bot that sends a warning to PRs that have not
> received any commits for 5 months [1] and closes them if nothing happens in
> the next month, asking to open an issue instead. Despite my apprehensions,
> I found this worked quite well, drawing back attention to forgotten PRs
> (and forcing one to consider if they best remain forgotten).
>
> Would there be interest in such a scheme?
>

My $2c: I've had this "bot experience" happen to me once (for a pip
contribution), and that left a *really* bad taste. Reading the message
below, that would do the same. E.g. no one bothered to review my PR in 5
months, and now you're asking me to rebase? If that's asked for, them much
better if a human does it.

Other thought: there were a number of people uncomfortable with the pep8
bot we used to have. This one would be more intrusive.

Cheers,
Ralf



>
> All the best,
>
> Marten
>
> p.s. We don't do anything with issues.
>
> [1] Text of the astropy-bot warning:
>
> Hi humans [image: wave] - this pull request hasn't had any new commits
> for approximately 5 months. *I plan to close this in a month if the pull
> request doesn't have any new commits by then.*
>
> In lieu of a stalled pull request, please consider closing this and open
> an issue instead if a reminder is needed to revisit in the future.
> Maintainers may also choose to add keep-open label to keep this PR open
> but it is discouraged unless absolutely necessary.
>
> If this PR still needs to be reviewed, as an author, you can rebase it to
> reset the clock. You may also consider sending a reminder e-mail about it
> to the astropy-dev mailing list
> <http://groups.google.com/group/astropy-dev>.
>
> *If you believe I commented on this pull request incorrectly, please
> report this here <https://github.com/astropy/astropy-bot/issues>.*
>
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion at python.org
> https://mail.python.org/mailman/listinfo/numpy-discussion
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20180925/cd9e0b84/attachment.html>


More information about the NumPy-Discussion mailing list