[Numpy-discussion] PR Cleanup
harrigan.matthew at gmail.com
Tue Sep 25 20:08:32 EDT 2018
PR 8528 <https://github.com/numpy/numpy/pull/8528> adds logical gufuncs
such as " all equal". The functionality has been mentioned quite a few
times on this list. Many implementations are in the PR and they are decent
IMHO. The hard part is the API and current ufunc code. Initially I
thought they would be top level functions, ie np.all_equal, but there
appears to be general consensus that they should be ufunc methods, ie
np.equal.all. Its not clear to me at least how that should be done.
Adding all, any, and first methods to all ufuncs seems bad. Some sort of
monkeypatch hack also seems bad. Rewriting the ufunc code to make the
methods specific to each ufunc, likely breaking the abi/api, is a big
effort. Suggestions welcome. Thank you.
On Tue, Sep 25, 2018 at 6:56 PM Allan Haldane <allanhaldane at gmail.com>
> On 09/25/2018 11:51 AM, Charles R Harris wrote:
> > Hi All,
> > As usual, the top of the PR stack is getting all the attention. As a
> > start on cleaning up the old PRs, I'd like to suggest that all the
> > maintainers look at their (long) pending PRs and decide which they want
> > to keep, close those they don't want to pursue, and rebase the others.
> > Might also help if they would post here the PRs that they think we
> > should finish up.
> PR 6377  fixes up alignment bugs which cause complex64/128 to be
> incorrectly aligned, which in turn causes further bugs. Eg,
> "np.dtype('c8').alignment" is 8 but should be 4 on most systems.
> The PR is in a finished state, modulo reviews. If anyone has access to
> sparc/aarch systems it would be great to test it, though.
>  https://github.com/numpy/numpy/pull/6377
> NumPy-Discussion mailing list
> NumPy-Discussion at python.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the NumPy-Discussion