[Numpy-discussion] PR Cleanup

Daπid davidmenhur at gmail.com
Wed Sep 26 08:05:42 EDT 2018


On Tue, 25 Sep 2018 at 21:14, Ralf Gommers <ralf.gommers at gmail.com> wrote:

>
>
> On Tue, Sep 25, 2018 at 5:35 PM Marten van Kerkwijk <
> m.h.vankerkwijk at gmail.com> wrote:
>
>> Hi Chuck,
>>
>> Over at astropy we have a bot that sends a warning to PRs that have not
>> received any commits for 5 months [1] and closes them if nothing happens in
>> the next month, asking to open an issue instead. Despite my apprehensions,
>> I found this worked quite well, drawing back attention to forgotten PRs
>> (and forcing one to consider if they best remain forgotten).
>>
>> Would there be interest in such a scheme?
>>
>
> My $2c: I've had this "bot experience" happen to me once (for a pip
> contribution), and that left a *really* bad taste. Reading the message
> below, that would do the same. E.g. no one bothered to review my PR in 5
> months, and now you're asking me to rebase? If that's asked for, them much
> better if a human does it.
>
> Other thought: there were a number of people uncomfortable with the pep8
> bot we used to have. This one would be more intrusive.
>
> Cheers,
> Ralf
>
>
I think Tensorflow does it better. Their butler-bot nags the core developer
assigned to the PR or issue if the report isn't marked as awaiting
information or suggestions pending. I think this is much nicer for external
contributors. On the other hand, TF has paid staff to take care of this,
here it would be up to you guys if you feel up to being nagged by robots.

Exact text:

Nagging Assignee @rohan100jain <https://github.com/rohan100jain>: It has
been 14 days with no activity and this issue has an assignee. Please update
the label and/or status accordingly.

https://github.com/tensorflow/tensorflow/issues/22180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20180926/b0dfb1e1/attachment-0001.html>


More information about the NumPy-Discussion mailing list