[Numpy-discussion] Converting np.sinc into a ufunc

[Stephan Hoyer]

On Wed, May 22, 2019 at 2:00 PM Ralf Gommers <ralf.gommers at gmail.com> wrote:

>
>
> On Wed, May 22, 2019 at 7:34 PM Nathan Goldbaum <nathan12343 at gmail.com>
> wrote:
>
>> It might be worth using BigQuery to search the github repository public
>> dataset for usages of np.sinc with keyword arguments.
>>
>
> We spent some effort at Quansight to try different approaches to this.
> BigQuery turns out to be suboptimal, parsing code with ast.parse is more
> robust. Chris Ostrouchov just released some code for this (blog post with
> details to follow) and the results of running that code:
> https://github.com/Quansight-Labs/python-api-inspect/blob/master/data/numpy-summary.csv
>
> np.sinc has 35 usages. to put that in perspective, np.array has ~31,000,
> np.dot ~2200, np.floor ~220, trace/inner/spacing/copyto are all similar to
> sinc.
>

Searching Google's internal code base (including open source dependencies),
I found many uses of np.sinc, but no uses of the keyword argument "x".

I think it's pretty safe to go ahead here.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20190522/eb65d2ef/attachment.html>